Skip to content

Enable 'num_workers: 0' default on jobs #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

Enable 'num_workers: 0' default on jobs #2792

merged 1 commit into from
May 1, 2025

Conversation

denik
Copy link
Contributor

@denik denik commented Apr 30, 2025 •
edited
Loading

Changes

  • Set default num_workers=0 on jobs
  • Move SingleNodeCluster() validator to run before applying defaults, otherwise it complains about num_workers being 0 even though users did not set it.

Why

See #2767 for justification.
Needed for #2791

Tests

Existing tests.

@denik denik temporarily deployed to test-trigger-is April 30, 2025 16:06 — with GitHub Actions Inactive
@denik denik added this pull request to the merge queue May 1, 2025
Merged via the queue into main with commit c3e60a0 May 1, 2025
10 checks passed
@denik denik deleted the denik/num_workers0 branch May 1, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewnester andrewnester andrewnester approved these changes

@pietern pietern Awaiting requested review from pietern pietern is a code owner

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

@anton-107 anton-107 Awaiting requested review from anton-107 anton-107 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denik @andrewnester