-
Notifications
You must be signed in to change notification settings - Fork 89
Initial implementation of "direct" deployment backend #2926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
denik
wants to merge
40
commits into
main
Choose a base branch
from
denik/remove-terraform2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
d378b22
WIP - deploying without terraform
denik de01085
shortenv env var names to avoid "The directory name is invalid" on wi…
denik c38b9fa
disable acc/cloud tests that don't work yet
denik e26060e
clean up
denik 631fd4b
WIP: destroy mutator + test (pipelines only); Graph is now generic
denik 838f58a
destroy for jobs + test
denik 4e15bca
update github action to use ENVFILTER
denik 41bf928
lint fix
denik a2d698d
do not create empty resources.json
denik da61418
clean up env var from tests
denik e15b814
enable test
denik 97dfb52
disable dashboard tests
denik 2858259
fix script
denik 2e67b61
enable run-local test
denik a5f2472
disable jobs/check-metadata, mlops-stacks
denik acfa3c8
disable 2 more integration tests
denik 9b3f2b0
disable volumes
denik 98c9e94
comment why test is disabled
denik 93e6783
Add resource_types.go + test
denik 7df6250
remove switch from GetResourceConfig
denik 9ac99ed
rename terranova_{state,resources} to tn{state,resources}
denik 7046c3b
clean up unused functions from testserver
denik e8178cb
add map with New functions that records resource types
denik 95a84dc
update comments
denik 38f8108
clean up
denik 83d774d
clean up
denik af7d514
lint fix
denik 5b1025c
resourceConstructors -> supportedResources
denik 7225442
extract IsDirectDeployment function
denik ee74ff2
dag: maintain insertion order, do not sort and do not require Less()
denik b36d55e
simplify cycle message
denik f6f303a
rename libs/dag to libs/dagrun
denik 13b449d
clean up; do not ignore errors
denik e3335f0
post-rebase fix of test.toml + update outputs
denik 9cd15e0
post rebase - restore acceptance/bundle/run/basic/test.toml
denik d59d9cc
clean up warning
denik 618b8d6
clean up; add comments; add error wrapping; use atomic
denik 02b5abb
add comments
denik 0d222dc
rm dec.DisallowUnknownFields
denik 46241f4
state: use GetResourceEntry to replace both GetResourceID and GetSave…
denik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
# Terraform sorts tasks | ||
EnvMatrix.DATABRICKS_CLI_DEPLOYMENT = ["terraform"] | ||
|
||
[[Repls]] | ||
Old = '\\\\' | ||
New = '/' | ||
|
1 change: 1 addition & 0 deletions
1
acceptance/bundle/artifacts/whl_prebuilt_outside_dynamic/test.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
EnvMatrix.DATABRICKS_CLI_DEPLOYMENT = ["terraform"] # dashboard not supported yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
acceptance/bundle/deploy/jobs/double-underscore-keys/test.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
Local = true | ||
Cloud = true | ||
|
||
EnvMatrix.DATABRICKS_CLI_DEPLOYMENT = ["terraform"] # needs investigation Error: deploying jobs.foo: Method=Jobs.Create *retries.Err *apierr.APIError StatusCode=400 ErrorCode="INVALID_PARAMETER_VALUE" Message="Missing required field: settings.tasks.task_key." | ||
|
||
Ignore = [ | ||
"databricks.yml", | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
Local = true | ||
Cloud = true | ||
|
||
EnvMatrix.DATABRICKS_CLI_DEPLOYMENT = ["terraform"] # requires "bundle summary" | ||
|
||
Ignore = [ | ||
"databricks.yml" | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
Cloud = true | ||
Local = true | ||
|
||
EnvMatrix.DATABRICKS_CLI_DEPLOYMENT = ["terraform"] | ||
|
||
Ignore = [ | ||
"databricks.yml", | ||
] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
BundleConfig.default_name.bundle.name = "test-bundle-$UNIQUE_NAME" | ||
BundleConfigTarget = "databricks.yml.tmpl" | ||
|
||
EnvMatrix.DATABRICKS_CLI_DEPLOYMENT = ["terraform"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# "bundle summary" is not implemented | ||
EnvMatrix.DATABRICKS_CLI_DEPLOYMENT = ["terraform"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.