Skip to content

testserver: Fix pipelines update to set default for storage #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025

Conversation

denik
Copy link
Contributor

@denik denik commented May 30, 2025

Why

This is the default that is set by backend if field is missing in Create/Update request. We already have Create covered, this applies it to Update.

Discovered while working on terraform removal #2926
Terraform reads the pipeline from the backend and then adds those defaults to future update requests while the new deployment backend does not read anything from the backend and those fields remain empty in update requests. The end result (as measured by "pipelines get $id") is, however, the same.

@denik denik temporarily deployed to test-trigger-is May 30, 2025 14:06 — with GitHub Actions Inactive
@denik denik changed the title acc: Fix pipelines update to set default for storage testserver: Fix pipelines update to set default for storage May 30, 2025
@denik denik temporarily deployed to test-trigger-is May 30, 2025 14:13 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is May 30, 2025 14:18 — with GitHub Actions Inactive
@denik denik force-pushed the denik/acc-pipelines branch from 8c360ef to 51ab137 Compare May 30, 2025 14:18
@denik denik temporarily deployed to test-trigger-is May 30, 2025 14:18 — with GitHub Actions Inactive
@denik denik enabled auto-merge May 30, 2025 14:19
@denik denik temporarily deployed to test-trigger-is June 2, 2025 15:44 — with GitHub Actions Inactive
@denik denik added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit ecb6307 Jun 3, 2025
10 checks passed
@denik denik deleted the denik/acc-pipelines branch June 3, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants