acc: extract common repls; support order for repls #2972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use common replacement for timestamps and numbers - Add Order property to [[Repls]]. Lowest Order is applied first. Default is 0.
denik
requested review from
pietern,
andrewnester,
shreyas-goenka and
anton-107
as code owners
pietern
reviewed
Jun 2, 2025
| #[[Repls]] | ||
| #Old = '\d+\?o=\d+' | ||
| #New = '[NUMBER]' | ||
|
|
| [[Repls]] | ||
| Old = '\?o=\[NUMID\]' | ||
| New = '' | ||
| Order = 1000 |
There was a problem hiding this comment.
Why remove both if they are stable?
There was a problem hiding this comment.
It's not stable, ?o= suffix is completely missing in some workspaces. Added this comment.
| [[Repls]] | ||
| Old = '17\d{11}' | ||
| New = '"UNIX_TIME_MILLIS"' | ||
|
|
There was a problem hiding this comment.
This was quoted to keep the request log valid JSON.
I recall discussing this with @shreyas-goenka a while back.
There was a problem hiding this comment.
Interesting. Why does it need to be valid json?
There was a problem hiding this comment.
To extract relevant chunks with jq. IIRC this was the case for telemetry tests.
There was a problem hiding this comment.
That should work. Replacements are applied after script is finished running. During script run it's unprocessed.
pietern
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
[[Repls]]object: Order. This defines order in which replacements are applied.[TEST_JOB_ID+0]replacement, little value and does not work when making test support both local and cloud.Why
Different tests are re-doing the same work with different approaches, this adds standard way to do this.