testserver: match cloud API behavior for database_catalogs#4440
Merged
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
The real cloud API: - Assigns uid in CREATE response - Does not return create_database_if_not_exists in GET (write-only field) This causes the migrate test to exercise the code path where database_catalogs has an Update action (due to the field difference), which triggered a nil pointer panic before commit a0418ac. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
denik
force-pushed
the
denik/migrate-panic-testserver
branch
from
d1a60d6 to
309cc75
Compare
denik
changed the title
pietern
approved these changes
Feb 4, 2026
Collaborator
|
Commit: 309cc75
21 interesting tests: 9 RECOVERED, 5 SKIP, 4 flaky, 3 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: b8586f5
27 interesting tests: 10 flaky, 7 KNOWN, 5 SKIP, 5 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
This causes the migrate test to exercise the code path where
database_catalogs has an Update action (due to the field difference),
which triggered a nil pointer panic before commit a0418ac.
Tests
Revert #4438 - can now see panic with local testserver.