fix: override is_string/is_number/is_float type classification for Databricks types#1390
Open
psaikaushik wants to merge 3 commits intodatabricks:mainfrom
Open
fix: override is_string/is_number/is_float type classification for Databricks types#1390psaikaushik wants to merge 3 commits intodatabricks:mainfrom
psaikaushik wants to merge 3 commits intodatabricks:mainfrom
Conversation
Collaborator
|
HI @psaikaushik can you select |
sd-db
requested changes
Apr 21, 2026
Collaborator
sd-db
left a comment
There was a problem hiding this comment.
Let us look to add tests + update CHANGELOG
…lumn The base Column class type classification methods don't recognize Spark/Databricks type names like 'string', 'int', 'bigint', 'double'. This causes col.is_string() to return False for string columns and col.is_number() to return False for numeric columns. Override these methods on DatabricksColumn with the complete set of Databricks/Spark type names. Closes databricks#1380
b317432 to
e491e09
Compare
Contributor
Author
Rebased and also allowed edits for maintainers. thanks for pointing it out! @sd-db |
Contributor
Author
Added tests and also updated changelog |
e83556c to
2e6f1b6
Compare
…ricks#1380) Address review feedback: add parametrized unit tests covering all five overridden methods (is_string, is_integer, is_float, is_number, is_numeric) with true/false cases and case-insensitive checks, and add a CHANGELOG entry under 1.11.7. https://claude.ai/code/session_017ZAXMwLSnqz4FqvTt5H7D1
2e6f1b6 to
8948b0c
Compare
261e768 to
dbed48b
Compare
Contributor
Author
|
@sd-db : Fixed the broken formatting test. Please take a look now. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
col.is_string(),col.is_number(),col.is_float(), andcol.is_numeric()all returnFalsefor Databricks/Spark column types because the baseColumnclass only recognizes PostgreSQL-style type names.Closes #1380
Related: dbt-labs/dbt-spark#658
Root Cause
The base
Columnclass from dbt-adapters definesis_string()etc. using type name sets that include PostgreSQL types (text,character varying, etc.) but not Spark/Databricks types (string,int,bigint,double, etc.).DatabricksColumninherits fromSparkColumnwhich inherits from the baseColumn, but neither overrides these classification methods.Fix
Override
is_string(),is_number(),is_float(),is_integer(), andis_numeric()onDatabricksColumnwith the complete set of Spark/Databricks type names:string,varchar,char,text, etc.tinyint,smallint,int,integer,bigint,long,float,double,decimal,numeric,real(plusdecimal(p,s)variants)float,double,realtinyint,smallint,int,integer,bigint,longVerification
Checklist