[Fix] Support updating all attributes of databricks_model_serving
#4575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkvuong
reviewed
Mar 31, 2025
| } | ||
|
|
||
| // Update the rate limit configuration for a model serving endpoint. | ||
| func updateRateLimits(ctx context.Context, w *databricks.WorkspaceClient, name string, newRateLimits []serving.RateLimit, d *schema.ResourceData) error { |
There was a problem hiding this comment.
this endpoint is now deprecated, you can remove it
This API is deprecated for your Foundation Model endpoint. Please use AI Gateway to manage rate limits.
There was a problem hiding this comment.
@mgyucht - see Vuong's comment
renaudhartert-db
approved these changes
Apr 7, 2025
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently, it is only possible to update the config for
databricks_model_servingresources. The Serving Endpoints API exposes separate APIs for updating different elements of serving endpoints, including the config, tags, rate limits, and AI gateway configuration. Because of this, we need to call each API separately when requested by a user.This PR adds support for updating these attributes. The provider will use
ResourceData'sHasChanges()method to determine whether each corresponding update method needs to be called.From what I can tell, it is not possible to update the route-optimized setting for model serving endpoints, so I've marked it as
ForceNewto ensure endpoints are recreated appropriately if a user requests to enable or disable route optimization.Resolves #4564, Resolves #4038, Resolves #4589
Tests
TestAccModelServingtest, verifying that tags can be provided at creation, and that in update tags can be removed, updated, and added.