Skip to content

[Internal] Don't panic if a schema attribute is already set to desired value #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Feb 13, 2025

Changes

Imo, It's not critical to set the same parameter of an attribute to the same value

NO_CHANGELOG=true

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@alexott alexott requested review from a team as code owners February 13, 2025 11:36
@alexott alexott requested review from mgyucht and removed request for a team February 13, 2025 11:36
…value

Imo, It's not a critical to set the same parameter of an attribute to the same value

NO_CHANGELOG=true
Copy link
Contributor

@nkvuong nkvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexott do we need to update this for other attribute builder as well?

@alexott
Copy link
Contributor Author

alexott commented Feb 24, 2025

Let discuss it with @mgyucht

@alexott alexott temporarily deployed to test-trigger-is March 17, 2025 11:50 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4499
  • Commit SHA: b996794df1f006cd0b83fbe4369c8ce0b86ba5ac

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is March 17, 2025 11:51 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants