Skip to content

[Fix] Use latest etag for access_control_rule_set #4622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Fix] Use latest etag for access_control_rule_set #4622

wants to merge 2 commits into from

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Apr 8, 2025 •
edited
Loading

Changes

  • Fetch latest etag before update or delete
  • Store empty etag in state as we always fetch the latest

Tests

WIP

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@tanmay-db tanmay-db requested review from a team as code owners April 8, 2025 12:47
@tanmay-db tanmay-db requested review from mgyucht and removed request for a team April 8, 2025 12:47
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 12:47 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 12:47 — with GitHub Actions Inactive
@tanmay-db tanmay-db changed the title [Fix] Use latest etag for access_control_rule_set [Fix] Use latest etag for access_control_rule_set Apr 8, 2025
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 12:48 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 12:49 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4622
  • Commit SHA: 5e9bbc9c215f5faed6d65edc8903b380a2896c2b

Checks will be approved automatically on success.

@tanmay-db tanmay-db removed request for a team and mgyucht April 8, 2025 12:52
@tanmay-db tanmay-db marked this pull request as draft April 8, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tanmay-db