-
Notifications
You must be signed in to change notification settings - Fork 426
[Internal] Bug fixed in databricks_mws_workspaces
resource due to migration of resource to Go SDK
#4652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
databricks_mws_workspaces
resource due to migration of resource to Go SDK
@@ -2789,7 +2789,7 @@ func (c Network_SdkV2) ApplySchemaCustomizations(attrs map[string]tfschema.Attri | |||
attrs["vpc_endpoints"] = attrs["vpc_endpoints"].SetComputed() | |||
attrs["vpc_endpoints"] = attrs["vpc_endpoints"].(tfschema.ListNestedAttributeBuilder).AddValidator(listvalidator.SizeAtMost(1)).(tfschema.AttributeBuilder) | |||
attrs["vpc_id"] = attrs["vpc_id"].SetOptional() | |||
attrs["vpc_status"] = attrs["vpc_status"].SetOptional() | |||
attrs["vpc_status"] = attrs["vpc_status"].SetComputed() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlight
@@ -4166,7 +4166,7 @@ func (c Workspace_SdkV2) ApplySchemaCustomizations(attrs map[string]tfschema.Att | |||
attrs["storage_customer_managed_key_id"] = attrs["storage_customer_managed_key_id"].SetOptional() | |||
attrs["workspace_id"] = attrs["workspace_id"].SetOptional() | |||
attrs["workspace_name"] = attrs["workspace_name"].SetOptional() | |||
attrs["workspace_status"] = attrs["workspace_status"].SetOptional() | |||
attrs["workspace_status"] = attrs["workspace_status"].SetComputed() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Changes
Reverts change in #4633 and set computed for workspace_status and vpc_status until they are fixed internally.
Tests
N/A
make test
run locallydocs/
folderinternal/acceptance