Skip to content

[Internal] Bug fixed in databricks_mws_workspaces resource due to migration of resource to Go SDK #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 16, 2025

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Apr 16, 2025

Changes

Reverts change in #4633 and set computed for workspace_status and vpc_status until they are fixed internally.

Tests

N/A

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@tanmay-db tanmay-db requested review from a team as code owners April 16, 2025 11:35
@tanmay-db tanmay-db requested review from parthban-db and removed request for a team April 16, 2025 11:35
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 16, 2025 11:35 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 16, 2025 11:36 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 16, 2025 11:38 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 16, 2025 11:40 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 16, 2025 11:40 — with GitHub Actions Inactive
@tanmay-db tanmay-db changed the title Fix bug regression [Internal] Bug fixed in databricks_mws_workspaces resource due to migration of resource to Go SDK Apr 16, 2025
@@ -2789,7 +2789,7 @@ func (c Network_SdkV2) ApplySchemaCustomizations(attrs map[string]tfschema.Attri
attrs["vpc_endpoints"] = attrs["vpc_endpoints"].SetComputed()
attrs["vpc_endpoints"] = attrs["vpc_endpoints"].(tfschema.ListNestedAttributeBuilder).AddValidator(listvalidator.SizeAtMost(1)).(tfschema.AttributeBuilder)
attrs["vpc_id"] = attrs["vpc_id"].SetOptional()
attrs["vpc_status"] = attrs["vpc_status"].SetOptional()
attrs["vpc_status"] = attrs["vpc_status"].SetComputed()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlight

@@ -4166,7 +4166,7 @@ func (c Workspace_SdkV2) ApplySchemaCustomizations(attrs map[string]tfschema.Att
attrs["storage_customer_managed_key_id"] = attrs["storage_customer_managed_key_id"].SetOptional()
attrs["workspace_id"] = attrs["workspace_id"].SetOptional()
attrs["workspace_name"] = attrs["workspace_name"].SetOptional()
attrs["workspace_status"] = attrs["workspace_status"].SetOptional()
attrs["workspace_status"] = attrs["workspace_status"].SetComputed()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlight

Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 16, 2025 15:47 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4652
  • Commit SHA: cc02570932468908873ac2e6a263308d147379fb

Checks will be approved automatically on success.

@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 16, 2025 15:47 — with GitHub Actions Inactive
@tanmay-db tanmay-db added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit e6e847b Apr 16, 2025
12 checks passed
@tanmay-db tanmay-db deleted the fix-bug-regression branch April 16, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants