[Feature] Add TF support for setting DisableLegacyFeatures

[EmanueleFWM]

Changes

This PR adds TF support for the DisableLegacyFeatures account level setting.

Tests

• make test run locally
• relevant change in docs/ folder
• covered with integration tests in internal/acceptance
• using Go SDK
• using TF Plugin Framework

[alexott]

So it superceeds the https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/disable_default_legacy_access & https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/disable_legacy_dbfs_setting?

[EmanueleFWM]

This is for an account level setting, when this setting is toggled any new workspace that is created will have the disable_legacy_access and disable_legacy_dbfs workspace level settings turned on (but it does not overwrite the workspace level setting, i.e. you could still turn either of these two setting back off at the workspace level later)

[alexott]

There is a configuration drift that causes failure:

Error: -25T17:10:49.374Z [ERROR] sdk.helper_resource: Unexpected error:
  error=
  | After applying this test step, the non-refresh plan was not empty.
  | stdout:
  | 
  | 
  | Terraform used the selected providers to generate the following execution
  | plan. Resource actions are indicated with the following symbols:
  |   ~ update in-place
  | 
  | Terraform will perform the following actions:
  | 
  |   # databricks_disable_legacy_features_setting.this will be updated in-place
  |   ~ resource "databricks_disable_legacy_features_setting" "this" {
  |       - etag         = "ACi1L_0ASCQEADJIHR9QpeYBZJMJUHVhyKZtOkUSTdWb9qfF6kXMitMtnjUBSHpJG2v9-Zm08rscUBvPPl1T50fk_wIDBdI7wLXtkZ_X0if7dP0NJCwQkhyusnWkw4OEtefLLYRbrqh22BSLy6IgdKYaMkZJMM2QWHrrey1AB6RAAQMAHEXkrIT4S2YKCgEAAA==" -> null
  |         id           = "global"
  |       - setting_name = "default" -> null
  | 
  |         # (1 unchanged block hidden)
  |     }
  | 
  | Plan: 0 to add, 1 to change, 0 to destroy.

[EmanueleFWM]

There seems to be a bug, for account level settings if a customizeSchemaFunc is provided the default customization (setting etag and setting name to Computed) is not applied, see difference between here (workspace setting) and here (account setting)

Should I make a separate PR for the fix?

[alexott]

it's ok to fix in this PR

[EmanueleFWM]

fixed, should work now

[EmanueleFWM]

@alexott any updates oh this PR? any changes still needed from my side?

[github-actions]

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

• PR number: 4676
• Commit SHA: 9046f41c2993e8c4fec5fa07eb9f7787a703a15d

Checks will be approved automatically on success.