Format data_analyzer and text_generation_plugins
#370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghanse
requested review from
akshayamin,
howardwu-db,
nfx and
renardeinside
and removed request for
a team
ghanse
changed the title
data_analyzer, text_generation_pluginsdata_analyzer and text_generation_plugins
howardwu-db
requested changes
Oct 19, 2025
dbldatagen/data_analyzer.py
Outdated
| :param dfData: Source ``DataFrame`` to summarize | ||
| :param rowLimit: Number of rows to use for ``DataFrame`` summarization | ||
| :param dfSummary: Summary metrics ``DataFrame`` | ||
| :return: Summary metrics ``DataFrame`` with the added measure |
dbldatagen/text_generator_plugins.py
Outdated
| :param mname: Method name to invoke | ||
| :param args: Positional argumentss to pass to the Faker text generation method | ||
| :param _lib: Optional import alias of Faker library (dfault is ``"faker"``) |
dbldatagen/data_analyzer.py
Outdated
| result = f"""minValue={minValue}, maxValue={maxValue}, step=0.1""" | ||
| elif sqlType == TimestampType(): | ||
|
|
||
| elif isinstance(sqlType, types.DecimalType): |
There was a problem hiding this comment.
should we keep this as isinstance or replace with ==. If we want to have this take into account inheritance should we make the other typechecks also isinstance rather than ==?
There was a problem hiding this comment.
I noticed the input is the actual instance types.DecimalType(), so we need to use equality and we'll need to keep the heuristic minimum and maximum values.
howardwu-db
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Applies formatting and adds type hints to the following modules:
data_analyzer.pytext_generation_plugins.pyLinked issues
N/A
Requirements