Skip to content

simplified data type table#385

Merged
jd-foster merged 4 commits intodatacarpentry:mainfrom
alexthrelkeld:data-types
Mar 27, 2026
Merged

simplified data type table#385
jd-foster merged 4 commits intodatacarpentry:mainfrom
alexthrelkeld:data-types

Conversation

@alexthrelkeld
Copy link
Copy Markdown
Contributor

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Closes #316

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
Simplified the changes to the descriptions of the data types in SQLite, since SQLite & the DB Browser for SQLite only use these data types anyway. Though, I don't believe the discussion in #316 was quite correct about exactly what the data types are, and went by the documentation for SQLite: https://www.sqlite.org/datatype3.html

If any relevant discussions have taken place elsewhere, please provide links to these.

Details

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2025

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

Copy link
Copy Markdown
Contributor

@adamancer adamancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amlaenxc! Thanks for this pull request! I agree that including data types that do not appear in SQLite is confusing, and this seems like a good change to simplify the lesson a bit. I put a few suggestions here, let me know if you have any thoughts about them.

Comment thread episodes/00-sql-introduction.md Outdated
| NUMERIC(p,s) | Exact numerical, precision p, scale s. (Same as DECIMAL) |
| FLOAT(p) | Approximate numerical, mantissa precision p. A floating number in base 10 exponential notation. |
| TEXT | Character string |
| BLOB | Raw binary data |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not count on learners knowing what binary data is. You might include examples (image file, etc.)

Is BLOB in SQLite always binary? That's generally what BLOB implies but the definition here suggests the BLOB format just stores the data as is.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure what the documentation means for the BLOB datatype with regards to whether it is always stored as raw binary. In any case, I updated the description in the table to avoid referencing "binary data" and hopefully be more understandable.

Comment thread episodes/00-sql-introduction.md Outdated
| MULTISET | A variable-length and unordered collection of elements |
| XML | Stores XML data |

### SQL Data Type Quick Reference {#datatypediffs}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the quick reference table is a lot for the lesson but would like to retain this in learners/sql-cheat-sheet.md.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved that quick reference table to learners/sql-cheat-sheet.md, and added a column for SQLite since that is the main database platform used in this workshop.

@alexthrelkeld
Copy link
Copy Markdown
Contributor Author

alexthrelkeld commented Apr 22, 2025 via email

@jd-foster
Copy link
Copy Markdown
Contributor

Hi Alex, thanks for the contribution and sorry for the delay. I have done a pass over the information and fixed some of the database specifics and general formatting & wording. Please take a look and see if you're happy with this.

@adamancer I would appreciate your comments.

@alexthrelkeld
Copy link
Copy Markdown
Contributor Author

Yes, that seems good to me!

@jd-foster jd-foster merged commit 725be22 into datacarpentry:main Mar 27, 2026
1 check passed
github-actions Bot pushed a commit that referenced this pull request Mar 27, 2026
Auto-generated via `{sandpaper}`
Source  : 725be22
Branch  : main
Author  : alexthrelkeld <127440629+alexthrelkeld@users.noreply.github.com>
Time    : 2026-03-27 12:41:27 +0000
Message : Simplified data-type table in first episode (#385)

* simplified data type table

* improve descriptions in episode 1 data types table

* added data type quick reference table to cheat sheet

* Validation and clean-up of types in different database system

* Final fixes with references to vendor documentation

---------

Co-authored-by: James Foster <James.Foster@csiro.au>
github-actions Bot pushed a commit that referenced this pull request Mar 27, 2026
Auto-generated via `{sandpaper}`
Source  : 020fd02
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-03-27 12:43:10 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 725be22
Branch  : main
Author  : alexthrelkeld <127440629+alexthrelkeld@users.noreply.github.com>
Time    : 2026-03-27 12:41:27 +0000
Message : Simplified data-type table in first episode (#385)

* simplified data type table

* improve descriptions in episode 1 data types table

* added data type quick reference table to cheat sheet

* Validation and clean-up of types in different database system

* Final fixes with references to vendor documentation

---------

Co-authored-by: James Foster <James.Foster@csiro.au>
github-actions Bot pushed a commit that referenced this pull request Mar 31, 2026
Auto-generated via `{sandpaper}`
Source  : 020fd02
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-03-27 12:43:10 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 725be22
Branch  : main
Author  : alexthrelkeld <127440629+alexthrelkeld@users.noreply.github.com>
Time    : 2026-03-27 12:41:27 +0000
Message : Simplified data-type table in first episode (#385)

* simplified data type table

* improve descriptions in episode 1 data types table

* added data type quick reference table to cheat sheet

* Validation and clean-up of types in different database system

* Final fixes with references to vendor documentation

---------

Co-authored-by: James Foster <James.Foster@csiro.au>
github-actions Bot pushed a commit to jd-foster/sql-ecology-lesson that referenced this pull request Mar 31, 2026
Auto-generated via `{sandpaper}`
Source  : 725be22
Branch  : main
Author  : alexthrelkeld <127440629+alexthrelkeld@users.noreply.github.com>
Time    : 2026-03-27 12:41:27 +0000
Message : Simplified data-type table in first episode (datacarpentry#385)

* simplified data type table

* improve descriptions in episode 1 data types table

* added data type quick reference table to cheat sheet

* Validation and clean-up of types in different database system

* Final fixes with references to vendor documentation

---------

Co-authored-by: James Foster <James.Foster@csiro.au>
github-actions Bot pushed a commit to jd-foster/sql-ecology-lesson that referenced this pull request Mar 31, 2026
Auto-generated via `{sandpaper}`
Source  : 87df19a
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-03-31 09:54:18 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 725be22
Branch  : main
Author  : alexthrelkeld <127440629+alexthrelkeld@users.noreply.github.com>
Time    : 2026-03-27 12:41:27 +0000
Message : Simplified data-type table in first episode (datacarpentry#385)

* simplified data type table

* improve descriptions in episode 1 data types table

* added data type quick reference table to cheat sheet

* Validation and clean-up of types in different database system

* Final fixes with references to vendor documentation

---------

Co-authored-by: James Foster <James.Foster@csiro.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

review SQL data types

3 participants