Skip to content

group summary nodes by stage id #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

group summary nodes by stage id #27

wants to merge 16 commits into from

Conversation

snstrauss
Copy link

No description provided.

snstrauss added 16 commits March 11, 2025 12:13
@snstrauss
removed empty useEffect, and unified practically duplicated useEffect…
df587c5 
…s that call layout service
@snstrauss
create common flow elements builders for sharing between flat layout …
c69e07e 
…and grouped layout. added logic for creating grouped nodes and edges
@snstrauss
moved dagre layout helper into it's own file, as preparation for addi…
12d60c7 
…tion of grouped layout helper
@snstrauss
moved SqlLayoutService into it's own folder, and it is now using the …
eec6a45 
…external builders for clarity. added method for getting grouped layout
@snstrauss
SqlFlow can now call for either flat or grouped nodes and edges layou…
42d0c3e 
…ts, based on mock configuration
@snstrauss
added memoization to SummaryTab to prevent redundant re-renders
f4e84be
@snstrauss
separated SqlLayoutService class into stand alone functions - no real…
e0dac33 
… need for class when using modules
@snstrauss
adding internal edges
adeec6c
@snstrauss
added fix for when groupd id is 0
58e3c0c
@snstrauss
encapsulated logic for resolving groups and nodes edges in a function
efd2cfb
@snstrauss
added dagre layout function for getting positions of groups and inner…
4ebda51 
… nodes
@snstrauss
moved the various components of SqlFlow into directories
11229c4
@snstrauss
some fixes after moving of files
0fa57ef
@snstrauss
added StageGroupNode components. since they are the ones that render …
84b90c8 
…their own child node, there no really anymore need for all the 'inner edges' logic
@snstrauss
no more need for duplications of sqlToLayoutElements since both funct…
5ffad1b 
…ions basically do the same now, only with different building of nodes and edges
@snstrauss
turn off 'grouping by stage' mock configuration
d46bc51
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snstrauss @CLAassistant