fix: hide total for now #458
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on mobile On mobile view, when comparing two communities, the comparison table was showing an empty state if either community had no data. This prevented users from seeing available data for the other community. Now the mobile view behaves like desktop: - Shows tables independently for each community - Only shows global empty state when both communities have no data - Shows individual empty state per community when applicable - Hides comparison pills (total amount/number) when only one has data
…harts Remove the ordinate (Y-axis) from marchés publics and subventions charts: - ComparisonChart: hide Y-axis while keeping domain and formatting - DesktopEvolutionChart: hide Y-axis ticks and labels This provides a cleaner chart visualization while maintaining the proper data scaling and tooltip functionality.
- Add displayMode parameter to useChartData hook to distinguish between 'amounts' and 'counts' - Use formatNumberInteger for counts (displays "2" instead of "0") - Use formatMonetaryValue for amounts (displays "1,5 M€") - Fix type conversion in mergeWithRealData to ensure year matching works correctly - Update EvolutionChart and MobileEvolutionChart to pass displayMode Fixes the issue where small count values (e.g., 2 contracts) were being divided by 1000 or 1000000 for monetary formatting, resulting in 0 being displayed.
✅ Review app deployedCheck how your changes look like!
|
There was a problem hiding this comment.
Année 2023 à mettre en année de référence car les scores de transparence ne sont pas consolidés au delà.
Pas certains de comprendre les modifs des fichiers .py mais je te fais confiance là dessus
En tout, la carte est bien plus lisible. Good job.
Ça me semble plus pertinent de mettre le score agrégé en selection par défaut plutôt que le score MP (et ça fait écho à ce qui est fait côté fiche collectivité). Qu'en penses-tu ?
| try { | ||
| const searchParams = request.nextUrl.searchParams; | ||
| const codes = searchParams.getAll('codes'); | ||
| const year = searchParams.get('year') || '2024'; |
There was a problem hiding this comment.
Suggested change
| const year = searchParams.get('year') || '2024'; | |
| const year = searchParams.get('year') || '2023'; |
Les derniers scores de transparence ont été calculés sur 2023 et pas 2024. C'est pour ça qu'on a que des E sur les régions et départements (ce qui n'est pas le cas en 2023 même si ça reste pas élevé...)
| try { | ||
| const body = await request.json(); | ||
| const { codes } = body; | ||
| const { codes, year = 2024 } = body; |
There was a problem hiding this comment.
Suggested change
| const { codes, year = 2024 } = body; | |
| const { codes, year = 2023 } = body; |
| try { | ||
| const searchParams = request.nextUrl.searchParams; | ||
| const codes = searchParams.getAll('codes'); | ||
| const year = searchParams.get('year') || '2024'; |
There was a problem hiding this comment.
Suggested change
| const year = searchParams.get('year') || '2024'; | |
| const year = searchParams.get('year') || '2023'; |
| try { | ||
| const searchParams = request.nextUrl.searchParams; | ||
| const codes = searchParams.getAll('codes'); | ||
| const year = searchParams.get('year') || '2024'; |
There was a problem hiding this comment.
Suggested change
| const year = searchParams.get('year') || '2024'; | |
| const year = searchParams.get('year') || '2023'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.