Analyst/lounes_pfas_udi_annuel #148

LounesAbd · 2025-04-04T16:32:41Z

[OUTDATED]

Bilan annuel par UDI pour les résultats PFAS.

un notebook qui détaille les étapes de création de la query SQL
le modèle SQL 'int__resultats_pfas_udi_annuel'
MAJ de la documentation DBT et création de tests basiques

Je trouve la query finale un peu longue, mais je n'ai pas trouvé de manière plus simple de la faire. J'ai agrégé les infos en deux étapes :

1/ une fois par 'prelevement / udi / année' pour calculer les valeurs de chaque substance / groupe de substances
2/ une deuxième fois par 'udi / année' pour calculer les nb de prélèvements, dépassements et les ratios

Les conditions finales sont à valider avec GF. Quels sont les ratios à surveiller ? Je me suis plus ou moins basé sur ce qu'on a fait pour les derniers résultats...

[UPDATE 13/04]

Mise à jour de la query pour suivre le brief GF.

On a les colonnes de résultat suivantes :

ratio_depassements_limite_reg
resultat_limite_sanitaire

coderabbitai · 2025-04-04T16:32:48Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)

dbt_/models/intermediate/pfas/_int__pfas_models.yml is excluded by none and included by none
dbt_/models/intermediate/pfas/int__resultats_pfas_udi_annuel.sql is excluded by none and included by none
dbt_/models/intermediate/pfas/int__resultats_pfas_udi_dernier.sql is excluded by none and included by none
dbt_/tests/test__coverage_20pfas_4pfas_98pct.sql is excluded by none and included by none
dbt_/tests/test_pfas_results.sql is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…_udi_annuel

20k-P

Merci pour le travail :)

J'ai plusieurs remarques sur les choix de syntaxe qui sont différents de cvm. Mais rien de gênant.

La table finale ne respecte pas le modèle de données (plusieurs colonnes "ratio_depassements_XX" et "nb_depassements_XX" au lieu de "résultats" ou d'un seul pourcentage pour la carte ).
==> A clarifier avec GF

dbt_/models/intermediate/pfas/_int__pfas_models.yml

dbt_/models/intermediate/pfas/int__resultats_pfas_udi_annuel.sql

githubzey

Merci pour le travail.
Je n'ai pas eu du temps pour regarder en détail mais j'ai vu que tu as mis "la somme des 4 PFAS réglementaires dépasse le seuil de 0.1 µg/L." mais je crois que d'après le brief le seuil est 0.02 µg/L.

Et je pour cette partie
--> Au moins 1 PFAS ≥ valeur sanitaire (fait passer l’affichage total polluant en rouge)
J'ai vu votre discussions avec GF sur le doc brief et je pense qu'on devrait bien différencier (comprendre) les termes "limites réglementaires", "les valeurs sanitaires", "limite de qualité" etc. Je vais essayer de comprendre.

dbt_/models/intermediate/pfas/int__resultats_pfas_udi_annuel.sql

…annuel

…es specs GF.

…annuel

20k-P

Ajouter le fichier de test ici aussi :)

dbt_/models/intermediate/pfas/int__resultats_pfas_udi_annuel.sql

dbt_/models/intermediate/pfas/_int__pfas_models.yml

…annuel

LounesAbd · 2025-04-14T15:20:58Z

Merci pour la review @20k-P et @githubzey ! Modifications faites et fichier de test ajouté 🙌🏻

20k-P

J'ai l'impression que c'est ok

…annuel

LounesAbd added 2 commits April 4, 2025 18:08

resultats pfas udi annuel (model, dbt doc, notebook)

da387fa

fix dbt tests

a0ae34c

Merge remote-tracking branch 'upstream/main' into analyst/lounes_pfas…

2fc2cc2

…_udi_annuel

LounesAbd self-assigned this Apr 4, 2025

LounesAbd added the team-data-analyst label Apr 4, 2025

LounesAbd requested review from 20k-P, githubzey and jereze April 4, 2025 16:34

20k-P reviewed Apr 4, 2025

View reviewed changes

githubzey reviewed Apr 4, 2025

View reviewed changes

20k-P reviewed Apr 6, 2025

View reviewed changes

dbt_/models/intermediate/pfas/int__resultats_pfas_udi_annuel.sql Outdated Show resolved Hide resolved

LounesAbd added 5 commits April 10, 2025 16:59

fix: generic tests on PFAS models profile

b568f05

Merge remote-tracking branch 'upstream' into analyst/lounes_pfas_udi_…

20ce515

…annuel

Merge remote-tracking branch 'upstream' into analyst/lounes_pfas_udi_…

0f828ed

…annuel

fix : MAJ du modèle 'int__resultats_pfas_udi_annuel' avec les nouvell…

dda12d2

…es specs GF.

Merge remote-tracking branch 'upstream' into analyst/lounes_pfas_udi_…

3be0b02

…annuel

LounesAbd requested review from 20k-P and githubzey April 13, 2025 19:15

Merge remote-tracking branch 'upstream' into analyst/lounes_pfas_udi_…

4e781d9

…annuel

20k-P requested changes Apr 14, 2025

View reviewed changes

dbt_/models/intermediate/pfas/int__resultats_pfas_udi_annuel.sql Show resolved Hide resolved

dbt_/models/intermediate/pfas/_int__pfas_models.yml Outdated Show resolved Hide resolved

dbt_/models/intermediate/pfas/_int__pfas_models.yml Show resolved Hide resolved

LounesAbd added 3 commits April 14, 2025 14:03

Merge remote-tracking branch 'upstream' into analyst/lounes_pfas_udi_…

f506731

…annuel

fix : smalls fixes on model and dbt profile

8fbc680

feat : added dbt test file for pfas results

2b385ba

LounesAbd requested a review from 20k-P April 14, 2025 15:17

LounesAbd mentioned this pull request Apr 14, 2025

feat: use new file GF pfas udi dernier #163

Merged

20k-P previously approved these changes Apr 14, 2025

View reviewed changes

LounesAbd and others added 2 commits April 15, 2025 11:53

Merge remote-tracking branch 'upstream' into analyst/lounes_pfas_udi_…

ef0b977

…annuel

Merge branch 'main' into analyst/lounes_pfas_udi_annuel

346f2a5

merge tests

8d344fb

jereze dismissed 20k-P’s stale review via 8d344fb April 15, 2025 18:15

jereze added 3 commits April 15, 2025 20:40

ajoute test vérification de la couverture des 20 PFAS et 4 PFAS

0ac21cb

update pfas annuel

b9e49d0

Merge branch 'main' into analyst/lounes_pfas_udi_annuel

b9eb481

jereze approved these changes Apr 16, 2025

View reviewed changes

jereze merged commit 02afb91 into main Apr 16, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Analyst/lounes_pfas_udi_annuel #148

Analyst/lounes_pfas_udi_annuel #148

Uh oh!

LounesAbd commented Apr 4, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 4, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

20k-P left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

githubzey left a comment

Uh oh!

Uh oh!

20k-P left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LounesAbd commented Apr 14, 2025

Uh oh!

20k-P left a comment

Uh oh!

Uh oh!

Uh oh!

Analyst/lounes_pfas_udi_annuel #148

Analyst/lounes_pfas_udi_annuel #148

Uh oh!

Conversation

LounesAbd commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

20k-P left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

githubzey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

20k-P left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LounesAbd commented Apr 14, 2025

Uh oh!

20k-P left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

LounesAbd commented Apr 4, 2025 •

edited

Loading

coderabbitai bot commented Apr 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

20k-P left a comment •

edited

Loading