create dbt models for resultats commune, add dbt test when dbt folder… #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jereze
reviewed
Feb 27, 2025
| type: SMALLINT | ||
| tests: | ||
| - dbt_utils.expression_is_true: | ||
| expression: ">= 2016" |
There was a problem hiding this comment.
on a bien des données depuis 2016, non?
There was a problem hiding this comment.
On charge uniquement depuis 2020 pour reduire la taille de la database pour le moment
jereze
reviewed
Feb 27, 2025
| type: SMALLINT | ||
| tests: | ||
| - dbt_utils.expression_is_true: | ||
| expression: ">= 2020" |
jereze
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Ca me semble bon :)
Pour la partie dbt, je ne suis pas expert.
Pour le code SQL, ça me semble bon, en attente bien sûr de la validation dans #65, mais on pourra corriger à posteriori.
Micro détails:
- sur les années, c'est vrai qu'on va plutôt se limuter à >= 2020, mais on a quand même des données depuis 2016, non ?
- de mon côté, j'ai le
uv.lockfile qui a bougé après un sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.