lint

Author: davidhewitt

src/common.rs

@@ -294,7 +294,7 @@ fn invoke_array_scalars<R: InvokeResult>(
             if let Some(string_array) = nested_json_array(json_array, is_object_lookup(path)) {
                 inner::<R>(string_array, path, jiter_find)
             } else {
-                return exec_err!("unexpected json array type {:?}", other);
+                exec_err!("unexpected json array type {:?}", other)
             }
         }
     }
@@ -421,7 +421,7 @@ fn zip_apply<'a, R: InvokeResult>(
         DataType::Int64 => inner::<_, R>(json_array, path_array.as_primitive::<Int64Type>(), jiter_find),
         DataType::UInt64 => inner::<_, R>(json_array, path_array.as_primitive::<UInt64Type>(), jiter_find),
         other => {
-            return exec_err!(
+            exec_err!(
                 "unexpected second argument type, expected string or int array, got {:?}",
                 other
             )

src/json_as_text.rs

@@ -70,7 +70,7 @@ impl InvokeResult for StringArray {
     }
 
     fn append_value(builder: &mut Self::Builder, value: Option<Self::Item>) {
-        builder.append_option(value)
+        builder.append_option(value);
     }
 
     fn finish(mut builder: Self::Builder) -> DataFusionResult<ArrayRef> {

src/json_contains.rs

@@ -75,7 +75,7 @@ impl InvokeResult for BooleanArray {
     }
 
     fn append_value(builder: &mut Self::Builder, value: Option<Self::Item>) {
-        builder.append_option(value)
+        builder.append_option(value);
     }
 
     fn finish(mut builder: Self::Builder) -> Result<ArrayRef> {

src/json_get.rs

@@ -77,9 +77,9 @@ impl InvokeResult for JsonUnion {
 
     fn append_value(builder: &mut Self::Builder, value: Option<Self::Item>) {
         if let Some(value) = value {
-            builder.push(value)
+            builder.push(value);
         } else {
-            builder.push_none()
+            builder.push_none();
         }
     }
 

src/json_get_float.rs

@@ -71,7 +71,7 @@ impl InvokeResult for Float64Array {
     }
 
     fn append_value(builder: &mut Self::Builder, value: Option<Self::Item>) {
-        builder.append_option(value)
+        builder.append_option(value);
     }
 
     fn finish(mut builder: Self::Builder) -> DataFusionResult<ArrayRef> {