Skip to content

Conversation

@adriangb
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (484e74a) to head (ba419f8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   82.46%   82.58%   +0.11%     
==========================================
  Files          15       15              
  Lines        1169     1177       +8     
  Branches     1169     1177       +8     
==========================================
+ Hits          964      972       +8     
  Misses        144      144              
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

(TYPE_ID_OBJECT, Arc::new(Field::new("object", DataType::Utf8, false))),
(
TYPE_ID_ARRAY,
Arc::new(Field::new("array", DataType::Utf8, false).with_metadata(JSON_METADATA.clone())),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is init inside of a once lock, I think there's not much point having the metadata be in a cached static as well. Otherwise, this is fine.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I had missed that

@adriangb adriangb merged commit 1620453 into main Feb 12, 2025
7 checks passed
@adriangb adriangb deleted the json-fields branch February 12, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants