Skip to content

Conversation

@nicolasservel
Copy link
Contributor

@nicolasservel nicolasservel commented Jan 19, 2021

See ch59584

This PR:

  • adds better support for plugin & custom algorithms in the ML helpers, in particular when listing & getting algorithm settings
  • adds support for wait_guess_complete when creating clustering ML Task, to align with prediction MLTasks for which it is already available, and changes the default behavior to wait_guess_complete=True, which is what we want in the vast majority of cases
  • fixes a few things found while testing:
    • no fail if "plugin_python" key not in modeling, for clustering task when disable_all_algorithms
    • only register "impurity" for MLlib Random Forest, duplication previously broke instantiation of the algorithm settings

@shortcut-integration
Copy link

@instanceofme instanceofme changed the title Better suport custom plugin algos Better suport custom & plugin algos Jan 19, 2021
Co-authored-by: Adrien Lavoillotte <adrien.lavoillotte@dataiku.com>
Copy link
Contributor

@mhham mhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remarks

Copy link
Contributor

@samronsin samronsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the _get_plugin_algorithm_names method which breaks get_all_possible_algorithm_names and its downstream methods with Python 3.

Co-authored-by: Samuel O. Ronsin <samuel.ronsin@dataiku.com>
Copy link
Contributor

@samronsin samronsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@nicolasservel nicolasservel merged commit 3e60674 into master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants