-
Notifications
You must be signed in to change notification settings - Fork 29
Better suport custom & plugin algos #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better suport custom & plugin algos #117
Conversation
|
This pull request has been linked to Clubhouse Story #59584: Better support for custom & plugin algos in public ML api helpers. |
Co-authored-by: Adrien Lavoillotte <adrien.lavoillotte@dataiku.com>
mhham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor remarks
samronsin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to fix the _get_plugin_algorithm_names method which breaks get_all_possible_algorithm_names and its downstream methods with Python 3.
Co-authored-by: Samuel O. Ronsin <samuel.ronsin@dataiku.com>
samronsin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
See ch59584
This PR:
wait_guess_completewhen creating clustering ML Task, to align with prediction MLTasks for which it is already available, and changes the default behavior towait_guess_complete=True, which is what we want in the vast majority of casesdisable_all_algorithms