Skip to content

Conversation

@FlorentDev64
Copy link
Contributor

… on project

    [ch62224](https://app.clubhouse.io/dataiku/story/62224/api-to-get-project-creation-and-last-modification-date)

Two new method/routes added to reflect changes of PublicAPIProjectController (GET /projects/{projectKey}/interest, /projects/{projectKey}/timeline?itemCount)

… on project

        [ch62224](https://app.clubhouse.io/dataiku/story/62224/api-to-get-project-creation-and-last-modification-date)

	Two new method/routes added to reflect changes of PublicAPIProjectController (GET /projects/{projectKey}/interest, /projects/{projectKey}/timeline?itemCount)
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #62224: API to get project creation and last modification date.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 31, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.06%.

Quality metrics Before After Change
Complexity 2.41 ⭐ 2.39 ⭐ -0.02 👍
Method Length 31.79 ⭐ 31.79 ⭐ 0.00
Working memory 8.49 🙂 8.47 🙂 -0.02 👍
Quality 79.64% 79.70% 0.06% 👍
Other metrics Before After Change
Lines 1425 1458 33
Changed files Quality Before Quality After Quality Change
dataikuapi/dss/project.py 79.64% ⭐ 79.70% ⭐ 0.06% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
dataikuapi/dss/project.py DSSProject.new_recipe 17 🙂 180 😞 28 ⛔ 29.17% 😞 Try splitting into smaller methods. Extract out complex expressions
dataikuapi/dss/project.py DSSProject.duplicate 2 ⭐ 73 🙂 18 ⛔ 60.05% 🙂 Extract out complex expressions
dataikuapi/dss/project.py DSSProject.create_prediction_ml_task 2 ⭐ 75 🙂 14 😞 63.99% 🙂 Extract out complex expressions
dataikuapi/dss/project.py DSSProject.list_datasets 5 ⭐ 63 🙂 12 😞 65.84% 🙂 Extract out complex expressions
dataikuapi/dss/project.py DSSProject.list_streaming_endpoints 5 ⭐ 63 🙂 12 😞 65.84% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@apichery apichery added this to the 9.0.2 milestone Apr 9, 2021
@apichery apichery merged commit c6735c8 into release/9.0 Apr 9, 2021
@FlorentDev64 FlorentDev64 deleted the feature/dss-90-API_Modification branch April 12, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants