-
Notifications
You must be signed in to change notification settings - Fork 29
Add publish version method #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has been linked to Clubhouse Story #61775: API Deployer: add a publish_package method to DSSAPIService. |
Proper request param name
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.02%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
|
Do we want to merge the refacto from #141? |
|
Hmm not in this PR. It touches other places than the scope here. |
|
Yep that was my thought as well. Do we simply merge the sourcery PR into |
|
Maybe we want to wait until |
|
@instanceofme @marchelleboid can we merge this ? |
Since 9.0.1 has been released, seems like it can be merged now. Might want to double check with @AgatheG though. |
|
In fact as noticed by @instanceofme it adds a new method only available in DSS 9.0.2. |
[ch61775]
See corresponding PR on dip: https://github.com/dataiku/dip/pull/12374