Skip to content

Conversation

@AgatheG
Copy link
Contributor

@AgatheG AgatheG commented Apr 1, 2021

[ch61775]

See corresponding PR on dip: https://github.com/dataiku/dip/pull/12374

@AgatheG AgatheG requested a review from marchelleboid April 1, 2021 10:58
@AgatheG AgatheG self-assigned this Apr 1, 2021
@shortcut-integration
Copy link

@AgatheG AgatheG added this to the 9.0 milestone Apr 1, 2021
Proper request param name
@AgatheG AgatheG requested a review from marchelleboid April 1, 2021 17:34
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 1, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 2.33 ⭐ 2.32 ⭐ -0.01 👍
Method Length 31.02 ⭐ 31.06 ⭐ 0.04 👎
Working memory 8.43 🙂 8.42 🙂 -0.01 👍
Quality 79.91% 79.93% 0.02% 👍
Other metrics Before After Change
Lines 1508 1521 13
Changed files Quality Before Quality After Quality Change
dataikuapi/dss/apiservice.py 86.56% ⭐ 85.96% ⭐ -0.60% 👎
dataikuapi/dss/project.py 79.45% ⭐ 79.45% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
dataikuapi/dss/project.py DSSProject.new_recipe 17 🙂 180 😞 28 ⛔ 29.17% 😞 Try splitting into smaller methods. Extract out complex expressions
dataikuapi/dss/project.py DSSProject.duplicate 2 ⭐ 73 🙂 18 ⛔ 60.05% 🙂 Extract out complex expressions
dataikuapi/dss/project.py DSSProject.create_prediction_ml_task 2 ⭐ 75 🙂 14 😞 63.99% 🙂 Extract out complex expressions
dataikuapi/dss/project.py DSSProject.list_jupyter_notebooks 5 ⭐ 69 🙂 12 😞 64.92% 🙂 Extract out complex expressions
dataikuapi/dss/project.py DSSProject.list_datasets 5 ⭐ 63 🙂 12 😞 65.84% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@AgatheG
Copy link
Contributor Author

AgatheG commented Apr 2, 2021

Do we want to merge the refacto from #141?

@instanceofme
Copy link
Contributor

Hmm not in this PR. It touches other places than the scope here.

@AgatheG
Copy link
Contributor Author

AgatheG commented Apr 2, 2021

Yep that was my thought as well. Do we simply merge the sourcery PR into release/9.0 or should we open a CH card to do it?

@instanceofme
Copy link
Contributor

Maybe we want to wait until release/9.0 has been published as 9.0.1, but otherwise LGTM

@kevanescence
Copy link
Contributor

@instanceofme @marchelleboid can we merge this ?

@marchelleboid
Copy link
Contributor

@instanceofme @marchelleboid can we merge this ?

Since 9.0.1 has been released, seems like it can be merged now. Might want to double check with @AgatheG though.

@kevanescence
Copy link
Contributor

In fact as noticed by @instanceofme it adds a new method only available in DSS 9.0.2.
So let's wait for 9.0.2 to land.

@apichery apichery modified the milestones: 9.0, 9.0.2 Apr 9, 2021
@cstenac cstenac merged commit 08c031a into release/9.0 Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants