Skip to content

Feature/add rss decoding #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [Version 1.2.4](https://github.com/dataiku/dss-plugin-api-connect/releases/tag/v1.2.4) - Feature release - 2025-02-18

- Fix xml decoding for content type application/rss+xml

## [Version 1.2.3](https://github.com/dataiku/dss-plugin-api-connect/releases/tag/v1.2.3) - Feature and bugfix release - 2024-11-25

- Fix xml decoding for content type application/atom+xml
Expand Down
2 changes: 1 addition & 1 deletion plugin.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "api-connect",
"version": "1.2.3",
"version": "1.2.4",
"meta": {
"label": "API Connect",
"description": "Retrieve data from any REST API",
Expand Down
2 changes: 1 addition & 1 deletion python-lib/dku_constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ class DKUConstants(object):
API_RESPONSE_KEY = "api_response"
FORBIDDEN_KEYS = ["token", "password", "api_key_value", "secure_token"]
FORM_DATA_BODY_FORMAT = "FORM_DATA"
PLUGIN_VERSION = "1.2.3"
PLUGIN_VERSION = "1.2.4"
RAW_BODY_FORMAT = "RAW"
REPONSE_ERROR_KEY = "dku_error"
2 changes: 1 addition & 1 deletion python-lib/dku_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def extract_key_using_json_path(json_dictionary, json_path):
def is_reponse_xml(response):
content_types = response.headers.get("Content-Type", "").split(";")
for content_type in content_types:
if content_type in ["text/xml", "application/soap+xml", "application/xml", "application/atom+xml"]:
if content_type in ["text/xml", "application/soap+xml", "application/xml", "application/atom+xml", "application/rss+xml"]:
return True
return False

Expand Down