Add in situ XRD block that can handle temperature and electrochemical data #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
=======================================
Coverage 80.12% 80.12%
=======================================
Files 70 70
Lines 4794 4794
=======================================
Hits 3841 3841
Misses 953 953
🚀 New features to boost your workflow:
|
ml-evs
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
from
c562212 to
91f3404
Compare
datalab
|
|||||||||||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bes/xrd_insitu_block_pre_rebase
|
| Run status |
|
| Run duration | 07m 11s |
| Commit |
|
| Committer | Ben Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
216
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/batchSampleFeature.cy.js • 2 failed tests • End-to-end tests (chrome)
| Test | Artifacts | |
|---|---|---|
| Batch sample creation > checks the copied samples |
Test Replay
Screenshots
|
|
| Batch sample creation > checks the created samples |
Test Replay
Screenshots
|
|
be-smith
requested review from
BenjaminCharmes,
jdbocarsly and
ml-evs
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for XRD insitu data visualization by implementing a new XRDInsituBlock component and registering it as a custom block type. The changes enable users to visualize in-situ X-ray diffraction data alongside temperature or electrochemical data.
- Add
XRDInsituBlockcomponent for XRD insitu data visualization - Register the new component in the custom block types registry
- Enhance UV-Vis insitu block with scan time input functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
webapp/src/resources.js |
Imports and registers the new XRDInsituBlock component in the custom block types |
webapp/src/components/datablocks/XRDInsituBlock.vue |
Implements the complete XRD insitu visualization component with folder selection and data granularity controls |
webapp/src/components/datablocks/UVVisInsituBlock.vue |
Adds scan time input field to the existing UV-Vis insitu block |
ml-evs
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
from
5e04cde to
c7aff64
Compare
be-smith
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
from
fea1280 to
2e86260
Compare
be-smith
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
from
2e86260 to
913fa95
Compare
be-smith
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
from
1a664ff to
da1b336
Compare
ml-evs
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
from
373184f to
6b419a5
Compare
ml-evs
reviewed
Oct 13, 2025
ml-evs
approved these changes
Oct 15, 2025
ml-evs
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
2 times, most recently
from
948660a to
678bbbd
Compare
ml-evs
requested changes
Oct 30, 2025
Used folder select component for selecting folders remove.vue from component importing Removed duplicate .txt from cycleblock accepted file extensions
scna time behaviour - changed behaviour of scan time box for when it triggers a recalculation of the data Remove duplicate scan time entry
Removed isEchemMode from data and made it a boolean based on time_series_source, which has default log Switched to two buttong for mode Changed label to log Updated colour of new mode text Use released in situ plugin version
ml-evs
force-pushed
the
bes/xrd_insitu_block_pre_rebase
branch
from
7647a99 to
d252cac
Compare
ml-evs
added
enhancement
ml-evs
approved these changes
Oct 30, 2025
ml-evs
changed the title
ml-evs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add XRD insitu block for PR datalab-org/datalab-app-plugin-insitu#67
The new block should look as below with the option to toggle between modes