Skip to content

Conversation

@BenjaminCharmes
Copy link
Contributor

Changes

  • Modified get_graph_cy_format to filter out relationships pointing to non-existent/deleted items at the query level
  • Prevents "nonexistent source" errors in the graph view without modifying the database

Question

  • Deleted items are still present in synthesis_constituents and remain clickable (even if leading to errors). Should we handle this in the UI (disable links and/or different badge)?

@cypress
Copy link

cypress bot commented Oct 20, 2025

datalab    Run #3957

Run Properties:  status check passed Passed #3957  •  git commit d2d96946fc ℹ️: Merge 90841b9e2dae4fd9c7bfb5fee519e6292332d5e5 into 1a6d5e960c415f6c5e222fd99267...
Project datalab
Branch Review bc/filter-relationships
Run status status check passed Passed #3957
Run duration 07m 22s
Commit git commit d2d96946fc ℹ️: Merge 90841b9e2dae4fd9c7bfb5fee519e6292332d5e5 into 1a6d5e960c415f6c5e222fd99267...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.03%. Comparing base (63105fc) to head (90841b9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/routes/v0_1/graphs.py 57.14% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1378      +/-   ##
==========================================
- Coverage   80.10%   80.03%   -0.07%     
==========================================
  Files          70       70              
  Lines        4759     4763       +4     
==========================================
  Hits         3812     3812              
- Misses        947      951       +4     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/routes/v0_1/graphs.py 72.46% <57.14%> (-4.46%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants