Add Cypress e2e tests with authenticated user login via magic links #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1379 +/- ##
==========================================
- Coverage 80.44% 80.02% -0.43%
==========================================
Files 70 70
Lines 4771 4830 +59
==========================================
+ Hits 3838 3865 +27
- Misses 933 965 +32
🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/cypress-magiclink
|
| Run status |
|
| Run duration | 07m 46s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
354
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
reviewed
Oct 28, 2025
| return jsonify({"status": "success", "token": token, "email": email}), 200 | ||
|
|
||
|
|
||
| @AUTH.route("/logout", methods=["POST"]) |
There was a problem hiding this comment.
Let's keep the original route that exists in main.py and use that in the tests
ml-evs
added
enhancement
ml-evs
force-pushed
the
bc/cypress-magiclink
branch
from
dd19abf to
b809178
Compare
ml-evs
requested changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1363
Implements UI testing as authenticated users to catch bugs that only occur when logged in. Adds
/testing/create-magic-linkand/logoutendpoints, plus Cypress commandsloginViaTestMagicLink()andlogout(). Includes tests for authenticated sample creation, admin dashboard access, and multi-user sample visibility.