Invalidate objects when owning context goes away. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When gcc_jit_context is destroyed, it frees memory allocated for types, rvalues and other library objects. Meanwhile, Python objects representing these types, rvalues and others are unaware that context is gone, their _c_object pointer was freed and now points to an invalid address. This patch adds to every Object a weak reference to it's parent Context. When Context is destroyed callback is called to clean up the dangling pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way to deal with #7
This patch adds to every Object a weak reference to it's parent Context.
When Context is destroyed callback is called to clean up the dangling
pointer.