Add cluster_by in Snowflake dynamic table materialization config #1305
+139
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazliander
force-pushed
the
feat/issue-706
branch
from
0c26263 to
639efa1
Compare
While creating dynamic tables in the Snowflake, the adapter was not using the cluster by parameter. However there was a nice parser implemented in the catalogue integrations. By wrapping the existing parser implementing the dynamic table config parameter.
nazliander
force-pushed
the
feat/issue-706
branch
from
639efa1 to
86dc6e8
Compare
3 tasks
|
@colin-rogers-dbt Hi, apologies for the direct message! 👋 I noticed this PR has been waiting for some time and hasn’t been able to run on CI yet. It’s not urgent, but if anyone from the team has a chance to review it in the near future, that would be helpful. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #706
docs N/A
Problem
Clustering via the config is not a possibility with
dbt-snowflakewhile using the dynamic table materializations.People workaround using a
post-hook, which is not intuitive and not standardized.Solution
Pulling the
cluster_byparser into the dynamic table materialization.So that we can forward the clustering options that the dbt user intends to use in the dynamic table creation command.
Checklist