Skip to content

Commit 5b55953

Browse files
theyostalservicetheyostalservice
authored
Bump DSI Version (#1876)
Version BUUUUUUUMP This PR is just here to pull in the new transformations and such from dsi. Early commits in this PR will be pinned to commits while I'm working on feeding dbt-labs/dbt-semantic-interfaces#436 to the merge-asaurus. Snapshot updates reflect the fact that now(*) we produce more metrics to replace measures, reflecting the changes in structure for the new user YAML. (*) "now" is true, but ONLY IN TESTS. Because of a transformation rule that exists only in MF right now, we don't use the list of transformations directly from dsi. See upstack #1877 for the PR that brings these changes to prod. OTH, tests DO run on the default list of metric transformations from dsi, so the snapshots needed more immediate updating.
1 parent 3d347f2 commit 5b55953

File tree

6 files changed

+68
-2
lines changed

6 files changed

+68
-2
lines changed

‎.changes/unreleased/Under the Hood-20251003-080025.yaml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
kind: Under the Hood
2+
body: Bump dependence on dbt-semantic-interfaces to 0.9.3.dev4 to get newest transformations code.
3+
time: 2025-10-03T08:00:25.705141-07:00
4+
custom:
5+
Author: theyostalservice courtneyholcomb
6+
Issue: "387"

‎metricflow-semantics/requirements-files/requirements.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# This allows us to sync new, non-breaking changes to dbt-core without getting a version mismatch in dbt-mantle,
33
# which depends on a specific commit of DSI.
44
# bumping to 0.9.3 will cause test failures, so pinning to dev2 until fixed
5-
dbt-semantic-interfaces==0.9.3.dev2
5+
dbt-semantic-interfaces==0.9.3.dev4
66
graphviz>=0.18.2, <0.21
77
python-dateutil>=2.9.0, <2.10.0
88
rapidfuzz>=3.0, <4.0

‎metricflow-semantics/tests_metricflow_semantics/snapshots/test_sg_resolver_output.py/str/test_set_for_distinct_values_query__result.txt‎

Lines changed: 39 additions & 0 deletions
Large diffs are not rendered by default.

‎metricflow-semantics/tests_metricflow_semantics/snapshots/test_sg_resolver_output.py/str/test_set_for_measures__result.txt‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,13 @@ bookings:
5353
│ guest__average_booking_value │ guest │ METRIC │ JOINED,METRIC │ bookings_source │
5454
│ guest__average_instant_booking_value │ guest │ METRIC │ JOINED,METRIC │ bookings_source │
5555
│ guest__bookers │ guest │ METRIC │ JOINED,METRIC │ bookings_source │
56+
│ guest__bookers_fill_nulls_with_0_join_to_timespine │ guest │ METRIC │ JOINED,METRIC │ bookings_source │
5657
│ guest__booking__guest__approximate_continuous_booking_value_p99 │ booking,guest │ METRIC │ JOINED,METRIC │ bookings_source │
5758
│ guest__booking__guest__approximate_discrete_booking_value_p99 │ booking,guest │ METRIC │ JOINED,METRIC │ bookings_source │
5859
│ guest__booking__guest__average_booking_value │ booking,guest │ METRIC │ JOINED,METRIC │ bookings_source │
5960
│ guest__booking__guest__average_instant_booking_value │ booking,guest │ METRIC │ JOINED,METRIC │ bookings_source │
6061
│ guest__booking__guest__bookers │ booking,guest │ METRIC │ JOINED,METRIC │ bookings_source │
62+
│ guest__booking__guest__bookers_fill_nulls_with_0_join_to_timespine │ booking,guest │ METRIC │ JOINED,METRIC │ bookings_source │
6163
│ guest__booking__guest__booking_fees │ booking,guest │ METRIC │ JOINED,METRIC │ bookings_source │
6264
│ guest__booking__guest__booking_fees_per_booker │ booking,guest │ METRIC │ JOINED,METRIC │ bookings_source │
6365
│ guest__booking__guest__booking_payments │ booking,guest │ METRIC │ JOINED,METRIC │ bookings_source │
@@ -142,11 +144,13 @@ bookings:
142144
│ host__average_booking_value │ host │ METRIC │ JOINED,METRIC │ bookings_source │
143145
│ host__average_instant_booking_value │ host │ METRIC │ JOINED,METRIC │ bookings_source │
144146
│ host__bookers │ host │ METRIC │ JOINED,METRIC │ bookings_source │
147+
│ host__bookers_fill_nulls_with_0_join_to_timespine │ host │ METRIC │ JOINED,METRIC │ bookings_source │
145148
│ host__booking__host__approximate_continuous_booking_value_p99 │ booking,host │ METRIC │ JOINED,METRIC │ bookings_source │
146149
│ host__booking__host__approximate_discrete_booking_value_p99 │ booking,host │ METRIC │ JOINED,METRIC │ bookings_source │
147150
│ host__booking__host__average_booking_value │ booking,host │ METRIC │ JOINED,METRIC │ bookings_source │
148151
│ host__booking__host__average_instant_booking_value │ booking,host │ METRIC │ JOINED,METRIC │ bookings_source │
149152
│ host__booking__host__bookers │ booking,host │ METRIC │ JOINED,METRIC │ bookings_source │
153+
│ host__booking__host__bookers_fill_nulls_with_0_join_to_timespine │ booking,host │ METRIC │ JOINED,METRIC │ bookings_source │
150154
│ host__booking__host__booking_fees │ booking,host │ METRIC │ JOINED,METRIC │ bookings_source │
151155
│ host__booking__host__booking_fees_per_booker │ booking,host │ METRIC │ JOINED,METRIC │ bookings_source │
152156
│ host__booking__host__booking_payments │ booking,host │ METRIC │ JOINED,METRIC │ bookings_source │
@@ -232,11 +236,13 @@ bookings:
232236
│ listing__average_booking_value │ listing │ METRIC │ JOINED,METRIC │ bookings_source │
233237
│ listing__average_instant_booking_value │ listing │ METRIC │ JOINED,METRIC │ bookings_source │
234238
│ listing__bookers │ listing │ METRIC │ JOINED,METRIC │ bookings_source │
239+
│ listing__bookers_fill_nulls_with_0_join_to_timespine │ listing │ METRIC │ JOINED,METRIC │ bookings_source │
235240
│ listing__booking__listing__approximate_continuous_booking_value_p99 │ booking,listing │ METRIC │ JOINED,METRIC │ bookings_source │
236241
│ listing__booking__listing__approximate_discrete_booking_value_p99 │ booking,listing │ METRIC │ JOINED,METRIC │ bookings_source │
237242
│ listing__booking__listing__average_booking_value │ booking,listing │ METRIC │ JOINED,METRIC │ bookings_source │
238243
│ listing__booking__listing__average_instant_booking_value │ booking,listing │ METRIC │ JOINED,METRIC │ bookings_source │
239244
│ listing__booking__listing__bookers │ booking,listing │ METRIC │ JOINED,METRIC │ bookings_source │
245+
│ listing__booking__listing__bookers_fill_nulls_with_0_join_to_timespine │ booking,listing │ METRIC │ JOINED,METRIC │ bookings_source │
240246
│ listing__booking__listing__booking_fees │ booking,listing │ METRIC │ JOINED,METRIC │ bookings_source │
241247
│ listing__booking__listing__booking_fees_per_booker │ booking,listing │ METRIC │ JOINED,METRIC │ bookings_source │
242248
│ listing__booking__listing__booking_payments │ booking,listing │ METRIC │ JOINED,METRIC │ bookings_source │
@@ -552,6 +558,14 @@ account_balance:
552558
│ user__bio_added_ts__second │ │ TIME_DIMENSION │ JOINED │ accounts_source,users_ds_source │
553559
│ user__bio_added_ts__week │ │ TIME_DIMENSION │ DERIVED_TIME_GRANULARITY,JOINED │ accounts_source,users_ds_source │
554560
│ user__bio_added_ts__year │ │ TIME_DIMENSION │ DERIVED_TIME_GRANULARITY,JOINED │ accounts_source,users_ds_source │
561+
│ user__buy__user__buys │ buy,user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source │
562+
│ user__buy__user__buys_fill_nulls_with_0 │ buy,user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source │
563+
│ user__buy__user__buys_fill_nulls_with_0_join_to_timespine │ buy,user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source │
564+
│ user__buy__user__buys_month │ buy,user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source │
565+
│ user__buys │ user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source │
566+
│ user__buys_fill_nulls_with_0 │ user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source │
567+
│ user__buys_fill_nulls_with_0_join_to_timespine │ user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source │
568+
│ user__buys_month │ user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source │
555569
│ user__company │ │ ENTITY │ ENTITY,JOINED │ accounts_source,companies │
556570
│ user__company_name │ │ DIMENSION │ JOINED │ accounts_source,companies │
557571
│ user__created_at__alien_day │ │ TIME_DIMENSION │ DERIVED_TIME_GRANULARITY,JOINED │ accounts_source,users_ds_source │
@@ -643,6 +657,7 @@ account_balance:
643657
│ user__listing__user__average_booking_value │ listing,user │ METRIC │ JOINED,METRIC │ accounts_source,bookings_source,listings_latest │
644658
│ user__listing__user__average_instant_booking_value │ listing,user │ METRIC │ JOINED,METRIC │ accounts_source,bookings_source,listings_latest │
645659
│ user__listing__user__bookers │ listing,user │ METRIC │ JOINED,METRIC │ accounts_source,bookings_source,listings_latest │
660+
│ user__listing__user__bookers_fill_nulls_with_0_join_to_timespine │ listing,user │ METRIC │ JOINED,METRIC │ accounts_source,bookings_source,listings_latest │
646661
│ user__listing__user__booking_fees │ listing,user │ METRIC │ JOINED,METRIC │ accounts_source,bookings_source,listings_latest │
647662
│ user__listing__user__booking_fees_per_booker │ listing,user │ METRIC │ JOINED,METRIC │ accounts_source,bookings_source,listings_latest │
648663
│ user__listing__user__booking_payments │ listing,user │ METRIC │ JOINED,METRIC │ accounts_source,bookings_source,listings_latest │
@@ -717,10 +732,14 @@ account_balance:
717732
│ user__visit__user__visit_buy_conversion_rate_by_session │ visit,user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source,visits_source │
718733
│ user__visit__user__visit_buy_conversion_rate_with_monthly_conversion │ visit,user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source,visits_source │
719734
│ user__visit__user__visit_buy_conversions │ visit,user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source,visits_source │
735+
│ user__visit__user__visits │ visit,user │ METRIC │ JOINED,METRIC │ accounts_source,visits_source │
736+
│ user__visit__user__visits_fill_nulls_with_0_join_to_timespine │ visit,user │ METRIC │ JOINED,METRIC │ accounts_source,visits_source │
720737
│ user__visit_buy_conversion_rate │ user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source,visits_source │
721738
│ user__visit_buy_conversion_rate_7days │ user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source,visits_source │
722739
│ user__visit_buy_conversion_rate_7days_fill_nulls_with_0 │ user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source,visits_source │
723740
│ user__visit_buy_conversion_rate_by_session │ user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source,visits_source │
724741
│ user__visit_buy_conversion_rate_with_monthly_conversion │ user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source,visits_source │
725742
│ user__visit_buy_conversions │ user │ METRIC │ JOINED,METRIC │ accounts_source,buys_source,visits_source │
743+
│ user__visits │ user │ METRIC │ JOINED,METRIC │ accounts_source,visits_source │
744+
│ user__visits_fill_nulls_with_0_join_to_timespine │ user │ METRIC │ JOINED,METRIC │ accounts_source,visits_source │
726745
└────────────────────────────────────────────────────────────────────────────┴────────────────────────────────┴──────────────────┴────────────────────────────────────────┴────────────────────────────────────────────────────────────────┘

‎metricflow/engine/metricflow_engine.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -841,6 +841,8 @@ def list_metrics(self, include_dimensions: bool = True) -> List[Metric]:
841841
metric_lookup = self._semantic_manifest_lookup.metric_lookup
842842
metrics: List[Metric] = []
843843
for pydantic_metric in metric_lookup.get_metrics(metric_lookup.metric_references):
844+
if pydantic_metric.type_params.is_private:
845+
continue
844846
semantic_models = []
845847
for measure in pydantic_metric.input_measures:
846848
semantic_model_reference = (

0 commit comments

Comments
 (0)