Skip to content

Commit 8792314

Browse files
committed
Rename MetricLookup.linkable_elements_for_no_metrics_query to get_group_by_items_for_distinct_values_query
1 parent dffba3f commit 8792314

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

metricflow-semantics/metricflow_semantics/model/semantics/metric_lookup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def linkable_elements_for_measure(
129129
)
130130
return result.filter(element_filter)
131131

132-
def linkable_elements_for_no_metrics_query(
132+
def get_group_by_items_for_distinct_values_query(
133133
self, element_set_filter: GroupByItemSetFilter = GroupByItemSetFilter()
134134
) -> BaseGroupByItemSet:
135135
"""Return the reachable linkable elements for a dimension values query with no metrics."""

metricflow-semantics/metricflow_semantics/query/group_by_item/candidate_push_down/push_down_visitor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ def visit_no_metrics_query_node(self, node: NoMetricsGroupByItemSourceNode) -> P
464464
logger.debug(LazyFormat(lambda: f"Handling {node.ui_description}"))
465465
# This is a case for distinct dimension values from semantic models.
466466
candidate_group_by_items = (
467-
self._semantic_manifest_lookup.metric_lookup.linkable_elements_for_no_metrics_query()
467+
self._semantic_manifest_lookup.metric_lookup.get_group_by_items_for_distinct_values_query()
468468
)
469469
logger.debug(LazyFormat("Retrieved candidates", candidate_group_by_items=candidate_group_by_items))
470470
candidates_after_filtering = candidate_group_by_items.filter_by_spec_patterns(self._source_spec_patterns)

0 commit comments

Comments
 (0)