Rename MetricLookup.linkable_elements_for_no_metrics_query to get_group_by_items_for_distinct_values_query

plypaul · plypaul · commit 87923143c633 · 2025-10-02T12:36:07.000-07:00
diff --git a/metricflow-semantics/metricflow_semantics/model/semantics/metric_lookup.py b/metricflow-semantics/metricflow_semantics/model/semantics/metric_lookup.py
@@ -129,7 +129,7 @@ def linkable_elements_for_measure(
         )
         return result.filter(element_filter)
 
-    def linkable_elements_for_no_metrics_query(
+    def get_group_by_items_for_distinct_values_query(
         self, element_set_filter: GroupByItemSetFilter = GroupByItemSetFilter()
     ) -> BaseGroupByItemSet:
         """Return the reachable linkable elements for a dimension values query with no metrics."""
diff --git a/metricflow-semantics/metricflow_semantics/query/group_by_item/candidate_push_down/push_down_visitor.py b/metricflow-semantics/metricflow_semantics/query/group_by_item/candidate_push_down/push_down_visitor.py
@@ -464,7 +464,7 @@ def visit_no_metrics_query_node(self, node: NoMetricsGroupByItemSourceNode) -> P
             logger.debug(LazyFormat(lambda: f"Handling {node.ui_description}"))
             # This is a case for distinct dimension values from semantic models.
             candidate_group_by_items = (
-                self._semantic_manifest_lookup.metric_lookup.linkable_elements_for_no_metrics_query()
+                self._semantic_manifest_lookup.metric_lookup.get_group_by_items_for_distinct_values_query()
             )
             logger.debug(LazyFormat("Retrieved candidates", candidate_group_by_items=candidate_group_by_items))
             candidates_after_filtering = candidate_group_by_items.filter_by_spec_patterns(self._source_spec_patterns)
