Skip to content

Commit a0fcf05

Browse files
authored
Renames for the measures -> simple metrics migration - Part 2 (#1902)
This PR renames tests that reference `measures` to reference `simple metrics` instead.
1 parent 5e106c4 commit a0fcf05

File tree

156 files changed

+191
-463
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

156 files changed

+191
-463
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
kind: Under the Hood
2+
body: Renames for the `measures -> simple metrics` migration - Part 2
3+
time: 2025-10-13T14:08:23.664574-07:00
4+
custom:
5+
Author: plypaul
6+
Issue: "1902"

metricflow-semantics/metricflow_semantics/experimental/dsi/manifest_object_lookup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@
1313

1414
from metricflow_semantics.collection_helpers.mf_type_aliases import AnyLengthTuple, Pair, T
1515
from metricflow_semantics.collection_helpers.syntactic_sugar import mf_first_item, mf_flatten
16-
from metricflow_semantics.experimental.dsi.measure_model_object_lookup import SimpleMetricModelObjectLookup
1716
from metricflow_semantics.experimental.dsi.model_object_lookup import (
1817
ModelObjectLookup,
1918
)
19+
from metricflow_semantics.experimental.dsi.simple_metric_model_object_lookup import SimpleMetricModelObjectLookup
2020
from metricflow_semantics.experimental.metricflow_exception import MetricflowInternalError
2121
from metricflow_semantics.experimental.ordered_set import FrozenOrderedSet, MutableOrderedSet, OrderedSet
2222
from metricflow_semantics.experimental.semantic_graph.model_id import SemanticModelId

metricflow-semantics/metricflow_semantics/experimental/semantic_graph/builder/graph_builder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
from metricflow_semantics.experimental.semantic_graph.builder.entity_key_subgraph import (
1616
EntityKeySubgraphGenerator,
1717
)
18-
from metricflow_semantics.experimental.semantic_graph.builder.measure_subgraph import (
18+
from metricflow_semantics.experimental.semantic_graph.builder.metric_subgraph import ComplexMetricSubgraphGenerator
19+
from metricflow_semantics.experimental.semantic_graph.builder.simple_metric_subgraph import (
1920
SimpleMetricSubgraphGenerator,
2021
)
21-
from metricflow_semantics.experimental.semantic_graph.builder.metric_subgraph import ComplexMetricSubgraphGenerator
2222
from metricflow_semantics.experimental.semantic_graph.builder.subgraph_generator import SemanticSubgraphGenerator
2323
from metricflow_semantics.experimental.semantic_graph.builder.time_dimension_subgraph import (
2424
TimeDimensionSubgraphGenerator,
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
from typing_extensions import override
66

7-
from metricflow_semantics.experimental.dsi.measure_model_object_lookup import SimpleMetricModelObjectLookup
7+
from metricflow_semantics.experimental.dsi.simple_metric_model_object_lookup import SimpleMetricModelObjectLookup
88
from metricflow_semantics.experimental.semantic_graph.attribute_resolution.attribute_recipe_step import (
99
AttributeRecipeStep,
1010
)

metricflow-semantics/metricflow_semantics/instances.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
from metricflow_semantics.specs.entity_spec import EntitySpec
1717
from metricflow_semantics.specs.group_by_metric_spec import GroupByMetricSpec
1818
from metricflow_semantics.specs.instance_spec import InstanceSpec
19-
from metricflow_semantics.specs.measure_spec import SimpleMetricInputSpec
2019
from metricflow_semantics.specs.metadata_spec import MetadataSpec
2120
from metricflow_semantics.specs.metric_spec import MetricSpec
21+
from metricflow_semantics.specs.simple_metric_input_spec import SimpleMetricInputSpec
2222
from metricflow_semantics.specs.spec_set import InstanceSpecSet
2323
from metricflow_semantics.specs.time_dimension_spec import TimeDimensionSpec
2424
from metricflow_semantics.visitor import VisitorOutputT

metricflow-semantics/metricflow_semantics/query/group_by_item/candidate_push_down/push_down_visitor.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@
2828
GroupByItemResolutionNode,
2929
GroupByItemResolutionNodeVisitor,
3030
)
31-
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.measure_source_node import (
32-
SimpleMetricGroupByItemSourceNode,
33-
)
3431
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.metric_resolution_node import (
3532
ComplexMetricGroupByItemResolutionNode,
3633
)
@@ -40,17 +37,20 @@
4037
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.query_resolution_node import (
4138
QueryGroupByItemResolutionNode,
4239
)
40+
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.simple_metric_source_node import (
41+
SimpleMetricGroupByItemSourceNode,
42+
)
4343
from metricflow_semantics.query.group_by_item.resolution_path import MetricFlowQueryResolutionPath
4444
from metricflow_semantics.query.issues.group_by_item_resolver.invalid_use_of_date_part import (
4545
MetricExcludesDatePartIssue,
4646
)
4747
from metricflow_semantics.query.issues.group_by_item_resolver.no_common_items import NoCommonItemsInParents
48-
from metricflow_semantics.query.issues.group_by_item_resolver.no_matching_items_for_measure import (
49-
NoMatchingItemsForSimpleMetric,
50-
)
5148
from metricflow_semantics.query.issues.group_by_item_resolver.no_matching_items_for_no_metrics_query import (
5249
NoMatchingItemsForNoMetricsQuery,
5350
)
51+
from metricflow_semantics.query.issues.group_by_item_resolver.no_matching_items_for_simple_metric import (
52+
NoMatchingItemsForSimpleMetric,
53+
)
5454
from metricflow_semantics.query.issues.group_by_item_resolver.no_parent_candidates import NoParentCandidates
5555
from metricflow_semantics.query.issues.issues_base import (
5656
MetricFlowQueryResolutionIssueSet,

metricflow-semantics/metricflow_semantics/query/group_by_item/filter_spec_resolution/filter_spec_resolver.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@
3636
GroupByItemResolutionNode,
3737
GroupByItemResolutionNodeVisitor,
3838
)
39-
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.measure_source_node import (
40-
SimpleMetricGroupByItemSourceNode,
41-
)
4239
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.metric_resolution_node import (
4340
ComplexMetricGroupByItemResolutionNode,
4441
)
@@ -48,6 +45,9 @@
4845
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.query_resolution_node import (
4946
QueryGroupByItemResolutionNode,
5047
)
48+
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.simple_metric_source_node import (
49+
SimpleMetricGroupByItemSourceNode,
50+
)
5151
from metricflow_semantics.query.group_by_item.resolution_path import MetricFlowQueryResolutionPath
5252
from metricflow_semantics.query.issues.filter_spec_resolver.invalid_where import WhereFilterParsingIssue
5353
from metricflow_semantics.query.issues.issues_base import (

metricflow-semantics/metricflow_semantics/query/group_by_item/resolution_dag/dag_builder.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
from metricflow_semantics.model.semantics.metric_lookup import MetricLookup
1212
from metricflow_semantics.query.group_by_item.resolution_dag.dag import GroupByItemResolutionDag
1313
from metricflow_semantics.query.group_by_item.resolution_dag.input_metric_location import InputMetricDefinitionLocation
14-
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.measure_source_node import (
15-
SimpleMetricGroupByItemSourceNode,
16-
)
1714
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.metric_resolution_node import (
1815
ComplexMetricGroupByItemResolutionNode,
1916
)
@@ -23,6 +20,9 @@
2320
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.query_resolution_node import (
2421
QueryGroupByItemResolutionNode,
2522
)
23+
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.simple_metric_source_node import (
24+
SimpleMetricGroupByItemSourceNode,
25+
)
2626

2727
logger = logging.getLogger(__name__)
2828

metricflow-semantics/metricflow_semantics/query/group_by_item/resolution_dag/resolution_nodes/base_node.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@
1212
from metricflow_semantics.visitor import Visitable, VisitorOutputT
1313

1414
if TYPE_CHECKING:
15-
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.measure_source_node import (
16-
SimpleMetricGroupByItemSourceNode,
17-
)
1815
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.metric_resolution_node import (
1916
ComplexMetricGroupByItemResolutionNode,
2017
)
@@ -24,6 +21,9 @@
2421
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.query_resolution_node import (
2522
QueryGroupByItemResolutionNode,
2623
)
24+
from metricflow_semantics.query.group_by_item.resolution_dag.resolution_nodes.simple_metric_source_node import (
25+
SimpleMetricGroupByItemSourceNode,
26+
)
2727

2828

2929
@dataclass(frozen=True)

0 commit comments

Comments
 (0)