Skip to content

Commit edd4e74

Browse files
Get MF using the new dsi transformations
1 parent 3bc07c3 commit edd4e74

File tree

1 file changed

+6
-15
lines changed

1 file changed

+6
-15
lines changed

metricflow-semantics/metricflow_semantics/model/dbt_manifest_parser.py

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,8 @@
33
from dbt_semantic_interfaces.implementations.semantic_manifest import (
44
PydanticSemanticManifest,
55
)
6-
from dbt_semantic_interfaces.transformations.boolean_measure import (
7-
BooleanMeasureAggregationRule,
8-
)
9-
from dbt_semantic_interfaces.transformations.convert_count import ConvertCountToSumRule
10-
from dbt_semantic_interfaces.transformations.convert_median import (
11-
ConvertMedianToPercentileRule,
12-
)
13-
from dbt_semantic_interfaces.transformations.cumulative_type_params import SetCumulativeTypeParamsRule
146
from dbt_semantic_interfaces.transformations.names import LowerCaseNamesRule
15-
from dbt_semantic_interfaces.transformations.proxy_measure import CreateProxyMeasureRule
7+
from dbt_semantic_interfaces.transformations.pydantic_rule_set import PydanticSemanticManifestTransformRuleSet
168
from dbt_semantic_interfaces.transformations.semantic_manifest_transformer import (
179
PydanticSemanticManifestTransformer,
1810
)
@@ -27,17 +19,16 @@ def parse_manifest_from_dbt_generated_manifest(manifest_json_string: str) -> Pyd
2719
# this time, which causes failures with input measure resolution.
2820
# TODO: remove this transform call once the upstream changes are integrated into our dependency tree
2921
# TODO: align rules between DSI, here, and MFS (if possible!)
22+
rule_set = PydanticSemanticManifestTransformRuleSet()
3023
rules = (
3124
# Primary
3225
(LowerCaseNamesRule(),),
33-
# Secondary
26+
# Secondary - broken out into groups because we run DedupeMetricInputMeasuresRule in the middle.
3427
(
35-
CreateProxyMeasureRule(),
36-
BooleanMeasureAggregationRule(),
37-
ConvertCountToSumRule(),
38-
ConvertMedianToPercentileRule(),
28+
*rule_set.legacy_measure_update_rules,
3929
DedupeMetricInputMeasuresRule(), # Remove once fix is in core
40-
SetCumulativeTypeParamsRule(),
30+
*rule_set.convert_legacy_measures_to_metrics_rules,
31+
*rule_set.general_metric_update_rules,
4132
),
4233
)
4334
model = PydanticSemanticManifestTransformer.transform(raw_model, rules)

0 commit comments

Comments
 (0)