Skip to content

Conversation

@tlento
Copy link
Contributor

@tlento tlento commented Sep 9, 2024

MetricFlow's query input parameter processing runs through a
pattern matching/parsing step that then produces a parameter spec
for subsequent matching during group by resolution. In practice,
every query parameter either directly references or is derived
directly from one or more elements in a semantic manifest.

Converting a parameter into a corresponsing spec pattern for a
given query input can, therefore, benefit from access to
the semantic manifest lookup objects we provide. This will
allow us to do things like map custom granularities to their
corresponding base granularities when doing group by resolution.

This change simply makes the semantic manifest available to the
method that converts between the query input parameter and the
spec pattern. It isolates the availability of the semantic
manifest lookup to this method because the other methods in the
relevant classes should generally not be using the lookup to
perform their operations, and the change as implemented
here also has a more limited blast radius.

@cla-bot cla-bot bot added the cla:yes label Sep 9, 2024
Copy link
Contributor Author

tlento commented Sep 9, 2024

@github-actions
Copy link

github-actions bot commented Sep 9, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor Author

tlento commented Sep 18, 2024

Merge activity

  • Sep 18, 11:48 AM PDT: @tlento started a stack merge that includes this pull request via Graphite.
  • Sep 18, 11:50 AM PDT: Graphite rebased this pull request as part of a merge.
  • Sep 18, 11:54 AM PDT: @tlento merged this pull request with Graphite.

@tlento tlento changed the base branch from remove-python-object-parsing-module to graphite-base/1403 September 18, 2024 18:49
@tlento tlento changed the base branch from graphite-base/1403 to main September 18, 2024 18:49
MetricFlow's query input parameter processing runs through a
pattern matching/parsing step that then produces a parameter spec
for subsequent matching during group by resolution. In practice,
every query parameter either directly references or is derived
directly from one or more elements in a semantic manifest.

Converting a parameter into a corresponsing spec pattern for a
given query input can, therefore, benefit from access to
the semantic manifest lookup objects we provide. This will
allow us to do things like map custom granularities to their
corresponding base granularities when doing group by resolution.

This change simply makes the semantic manifest available to the
method that converts between the query input parameter and the
spec pattern. It isolates the availability of the semantic
manifest lookup to this method because the other methods in the
relevant classes should generally not be using the lookup to
perform their operations, and the change as implemented
here also has a more limited blast radius.
@tlento tlento force-pushed the make-semmantic-manifest-lookup-available-for-spec-patterns branch from 8c0a0f4 to 117d737 Compare September 18, 2024 18:49
@tlento tlento merged commit 9bd4b43 into main Sep 18, 2024
@tlento tlento deleted the make-semmantic-manifest-lookup-available-for-spec-patterns branch September 18, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants