Rename classes for group-by items #1870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
force-pushed
the
p/measure_migration__06
branch
from
0660f6e to
ef33735
Compare
courtneyholcomb
approved these changes
Sep 26, 2025
Contributor
courtneyholcomb
left a comment
courtneyholcomb
left a comment
There was a problem hiding this comment.
helpful changes, thank you!
| self.custom_granularities = TimeSpineSource.build_custom_granularities(list(self._time_spine_sources.values())) | ||
| self._semantic_model_lookup = SemanticModelLookup( | ||
| model=semantic_manifest, custom_granularities=self.custom_granularities | ||
| semantic_manifest=semantic_manifest, custom_granularities=self.custom_granularities |
Contributor
There was a problem hiding this comment.
this has been bugging me for so long and I never got around to fixing it haha thank you!
plypaul
force-pushed
the
p/measure_migration__05
branch
from
674d728 to
f8bc123
Compare
plypaul
force-pushed
the
p/measure_migration__06
branch
from
ef33735 to
1f73f48
Compare
…anticModelLookup()`
…ved_group_by_item_set`
plypaul
force-pushed
the
p/measure_migration__06
branch
from
1f73f48 to
70e479b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames a number of classes that handle group-by items away from the
Linkable*prefix. There are some additional renames related to field and argument names that will be handled later.