Assorted fixes for GroupByItemSetFilter
#1873
Merged
+114
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
approved these changes
Sep 26, 2025
plypaul
force-pushed
the
p/measure_migration__08
branch
from
0bc61a4 to
8791c10
Compare
plypaul
force-pushed
the
p/measure_migration__09
branch
from
6c38e57 to
21b3eef
Compare
plypaul
force-pushed
the
p/measure_migration__08
branch
from
8791c10 to
3408fe6
Compare
plypaul
force-pushed
the
p/measure_migration__09
branch
from
21b3eef to
8f4e9d8
Compare
plypaul
force-pushed
the
p/measure_migration__08
branch
from
3408fe6 to
f4f1cd7
Compare
plypaul
force-pushed
the
p/measure_migration__09
branch
from
8f4e9d8 to
6b8c8ac
Compare
plypaul
force-pushed
the
p/measure_migration__09
branch
from
97cb162 to
1af97bc
Compare
plypaul
force-pushed
the
p/measure_migration__09
branch
2 times, most recently
from
c6d5fd0 to
21f6c42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the names of the fields in
GroupByItemSetFilterto be more noun-like and adds.create()to make it easier to instantiate.