Skip to content

Conversation

@plypaul
Copy link
Contributor

@plypaul plypaul commented Oct 6, 2025

This PR removes MetricFlowEngine.get_measures_for_metrics to align with the measure -> simple metric migration.

@cla-bot cla-bot bot added the cla:yes label Oct 6, 2025
@plypaul plypaul marked this pull request as ready for review October 6, 2025 20:45
@plypaul plypaul requested a review from a team as a code owner October 6, 2025 20:45
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm we might need to patch this in MFS so that it doesn't abruptly stop working for customers / integrations. Me or Patrick should be able to do that

@courtneyholcomb
Copy link
Contributor

Put up a PR for the API issue https://github.com/dbt-labs/metricflow-server/pull/1617

@plypaul plypaul force-pushed the p/measure_migration__11 branch from e6c414e to 66bd27b Compare October 8, 2025 19:07
Base automatically changed from p/measure_migration__10 to main October 8, 2025 19:19
@plypaul plypaul force-pushed the p/measure_migration__11 branch from 66bd27b to 6e859fd Compare October 8, 2025 19:21
@plypaul plypaul merged commit 6b2f2c3 into main Oct 8, 2025
13 checks passed
@plypaul plypaul deleted the p/measure_migration__11 branch October 8, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants