Skip to content

Add a test for MetricLookup. get_aggregation_time_dimension_specs() #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

Add a test for MetricLookup. get_aggregation_time_dimension_specs() #1890

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
031f03d
/* PR_START p/measure_migration 14 */ Add test for agg time dimension…
plypaul Oct 8, 2025
0113333
Add changelog entry
plypaul Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions metricflow-semantics/tests_metricflow_semantics/model/test_semantic_model_container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,23 +71,15 @@ def test_get_semantic_models_for_entity(semantic_model_lookup: SemanticModelLook
assert len(linked_semantic_models) == 10


def test_get_valid_agg_time_dimensions_for_metric( # noqa: D103
metric_lookup: MetricLookup, semantic_model_lookup: SemanticModelLookup
def test_get_aggregation_time_dimension_specs( # noqa: D103
request: FixtureRequest,
mf_test_configuration: MetricFlowTestConfiguration,
metric_lookup: MetricLookup,
semantic_model_lookup: SemanticModelLookup,
) -> None:
result = {}
for metric_name in ["views", "listings", "bookings_per_view"]:
metric_reference = MetricReference(metric_name)
metric = metric_lookup.get_metric(metric_reference)
metric_agg_time_dims = metric_lookup.get_valid_agg_time_dimensions_for_metric(metric_reference)
measure_agg_time_dims = list(
{
semantic_model_lookup.measure_lookup.get_properties(
measure.measure_reference
).agg_time_dimension_reference
for measure in metric.input_measures
}
)
if len(measure_agg_time_dims) == 1:
for metric_agg_time_dim in metric_agg_time_dims:
assert metric_agg_time_dim.reference == measure_agg_time_dims[0]
else:
assert len(metric_agg_time_dims) == 0
specs = metric_lookup.get_aggregation_time_dimension_specs(MetricReference(metric_name))
result[metric_name] = list(spec.qualified_name for spec in specs)

assert_object_snapshot_equal(request=request, snapshot_configuration=mf_test_configuration, obj=result)
71 changes: 71 additions & 0 deletions ...st_semantic_model_container.py/dict/test_get_aggregation_time_dimension_specs__result.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
test_name: test_get_aggregation_time_dimension_specs
test_filename: test_semantic_model_container.py
---
{
'views': [
'view__ds__day',
'view__ds__week',
'view__ds__month',
'view__ds__quarter',
'view__ds__year',
'view__ds__extract_year',
'view__ds__extract_quarter',
'view__ds__extract_month',
'view__ds__extract_day',
'view__ds__extract_dow',
'view__ds__extract_doy',
'view__ds__alien_day',
'metric_time__day',
'metric_time__week',
'metric_time__month',
'metric_time__quarter',
'metric_time__year',
'metric_time__extract_year',
'metric_time__extract_quarter',
'metric_time__extract_month',
'metric_time__extract_day',
'metric_time__extract_dow',
'metric_time__extract_doy',
'metric_time__alien_day',
],
'listings': [
'listing__ds__day',
'listing__ds__week',
'listing__ds__month',
'listing__ds__quarter',
'listing__ds__year',
'listing__ds__extract_year',
'listing__ds__extract_quarter',
'listing__ds__extract_month',
'listing__ds__extract_day',
'listing__ds__extract_dow',
'listing__ds__extract_doy',
'listing__ds__alien_day',
'metric_time__day',
'metric_time__week',
'metric_time__month',
'metric_time__quarter',
'metric_time__year',
'metric_time__extract_year',
'metric_time__extract_quarter',
'metric_time__extract_month',
'metric_time__extract_day',
'metric_time__extract_dow',
'metric_time__extract_doy',
'metric_time__alien_day',
],
'bookings_per_view': [
'metric_time__day',
'metric_time__week',
'metric_time__month',
'metric_time__quarter',
'metric_time__year',
'metric_time__extract_year',
'metric_time__extract_quarter',
'metric_time__extract_month',
'metric_time__extract_day',
'metric_time__extract_dow',
'metric_time__extract_doy',
'metric_time__alien_day',
],
}