Add dimension_lookup to ModelObjectLookup
#1907
Open
+87
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return DimensionLookup(self._semantic_model.dimensions) | ||
|
|
||
| @cached_property | ||
| def resolved_primary_entity_name(self) -> str: |
Contributor
There was a problem hiding this comment.
Our primary entity validation seems to only guarantee that semantic models with dimensions have a primary entity (i.e., if you have a model with entities only it doesn't need to have a primary entity). Can we update this code to avoid erroring if we encounter a model like that?
Contributor
There was a problem hiding this comment.
We might not have any tests for this type of model, might be good to add one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
dimension_lookuptoModelObjectLookupas a small step towards migratingSemanticModelLookuptoModelObjectLookup. The goal of the migration was to simplify the lookup classes and to move more lookups to the semantic graph for performance reasons.