Update from parse to cast for the handling of the UTC time strings as the usage of the parse function appears to be preventing index usage.

Author: Benjamin-Knight

dbt/adapters/sqlserver/sqlserver_relation.py

@@ -58,19 +58,19 @@ def _render_event_time_filtered(self, event_time_filter: EventTimeFilter) -> str
         if event_time_filter.start and event_time_filter.end:
             filter = (
                 f"{event_time_filter.field_name} >="
-                f" parse('{event_time_filter.start}' as datetimeoffset)"
+                f" cast('{event_time_filter.start}' as datetimeoffset)"
                 f" and {event_time_filter.field_name} <"
-                f" parse('{event_time_filter.end}' as datetimeoffset)"
+                f" cast('{event_time_filter.end}' as datetimeoffset)"
             )
         elif event_time_filter.start:
             filter = (
                 f"{event_time_filter.field_name} >="
-                f" parse('{event_time_filter.start}' as datetimeoffset)"
+                f" cast('{event_time_filter.start}' as datetimeoffset)"
             )
         elif event_time_filter.end:
             filter = (
                 f"{event_time_filter.field_name} <"
-                f" parse('{event_time_filter.end}' as datetimeoffset)"
+                f" cast('{event_time_filter.end}' as datetimeoffset)"
             )
 
         return filter

dbt/include/sqlserver/macros/materializations/models/incremental/merge.sql

@@ -6,12 +6,12 @@
 
     {#-- Add additional incremental_predicates to filter for batch --#}
     {% if model.config.get("__dbt_internal_microbatch_event_time_start") -%}
-    {{ log("incremenal append event start time > DBT_INTERNAL_TARGET." ~ model.config.event_time ~ " >= parse('" ~ model.config.__dbt_internal_microbatch_event_time_start ~ "' as datetimeoffset)") }}
-        {% do incremental_predicates.append("DBT_INTERNAL_TARGET." ~ model.config.event_time ~ " >= parse('" ~ model.config.__dbt_internal_microbatch_event_time_start ~ "' as datetimeoffset)") %}
+    {{ log("incremental append event start time > DBT_INTERNAL_TARGET." ~ model.config.event_time ~ " >= cast('" ~ model.config.__dbt_internal_microbatch_event_time_start ~ "' as datetimeoffset)") }}
+        {% do incremental_predicates.append("DBT_INTERNAL_TARGET." ~ model.config.event_time ~ " >= cast('" ~ model.config.__dbt_internal_microbatch_event_time_start ~ "' as datetimeoffset)") %}
     {% endif %}
     {% if model.config.__dbt_internal_microbatch_event_time_end -%}
-    {{ log("incremenal append event end time < DBT_INTERNAL_TARGET." ~ model.config.event_time ~ " < parse('" ~ model.config.__dbt_internal_microbatch_event_time_end ~ "' as datetimeoffset)") }}
-        {% do incremental_predicates.append("DBT_INTERNAL_TARGET." ~ model.config.event_time ~ " < parse('" ~ model.config.__dbt_internal_microbatch_event_time_end ~ "' as datetimeoffset)") %}
+    {{ log("incremental append event end time < DBT_INTERNAL_TARGET." ~ model.config.event_time ~ " < cast('" ~ model.config.__dbt_internal_microbatch_event_time_end ~ "' as datetimeoffset)") }}
+        {% do incremental_predicates.append("DBT_INTERNAL_TARGET." ~ model.config.event_time ~ " < cast('" ~ model.config.__dbt_internal_microbatch_event_time_end ~ "' as datetimeoffset)") %}
     {% endif %}
     {% do arg_dict.update({'incremental_predicates': incremental_predicates}) %}