start_block config for cardano_node source #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feels reasonable to me, but maybe @gostkin you can check |
gostkin
reviewed
Dec 18, 2023
| .start_from(config.start_block) | ||
| .await | ||
| .context("Can't get starting point from sink")?; | ||
| tracing::info!("Passed start_block config: {:?}", config.start_block); |
There was a problem hiding this comment.
sink.start_from should be called anyway. doesn't matter if start_from is None. otherwise genesis data won't be processed
There was a problem hiding this comment.
carp/indexer/src/sinks/cardano.rs
Lines 131 to 134 in 26c085b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start_block was getting ignored for cardano_node source? check for the config, otherwise use latest from db.
Not tested with Oura as the source