Bug Fixes #1292
Bug Fixes #1292
Conversation
guillevalin
temporarily deployed
to
FROM_WALLET_PRIVATE_KEY
GitHub Actions
Inactive
guillevalin
temporarily deployed
to
FROM_WALLET_PRIVATE_KEY
GitHub Actions
Inactive
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| Ok(ShinkaiTool::Rust(existing_rust_tool, is_enabled)) => { | ||
| let mut upgraded_tool = rust_tool.clone(); | ||
| if upgraded_tool.mcp_enabled.is_none() { | ||
| upgraded_tool.mcp_enabled = existing_rust_tool.mcp_enabled; |
There was a problem hiding this comment.
[P1] Preserve MCP flag when upgrading Rust tools
The upgrade branch rebuilds the new RustTool and only copies mcp_enabled from the existing tool when the new definition leaves the flag unset. Because RustTool::new always initialises mcp_enabled to Some(false), this condition never fires and an upgrade will always overwrite any user‑chosen MCP value with false. Users who enabled MCP for a tool will find it disabled after a version bump. The upgrade path should carry over the previous mcp_enabled value regardless, unless a new default is explicitly intended.
Useful? React with 👍 / 👎.
guillevalin
temporarily deployed
to
FROM_WALLET_PRIVATE_KEY
GitHub Actions
Inactive
guillevalin
temporarily deployed
to
FROM_WALLET_PRIVATE_KEY
GitHub Actions
Inactive
No description provided.