Skip to content

feat: new parameter --useWsdlTypeNames to generate interface names from wsdl type names #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

doubleaxe
Copy link
Contributor

This PR should fix issue #58

I didn't have much time testing it, it works on my (complex) wsdl. Old tests pass, but I didn't write anything to test new functionality.

@dderevjanik
Copy link
Owner

Hi @doubleaxe

Thank you for the PR looks great, and I really appreciate your effort! 🎉
I tested it locally, and everything seems to work as expected.

To ensure the changes are complete and well-documented, could you please:

  • Add a unit test for the new functionality to help prevent future regressions
  • Update the documentation (new arguments) to reflect these changes

@doubleaxe
Copy link
Contributor Author

Hello @dderevjanik
I added small unit test, also fixed casing. I reverted second feature, option --stripNamespacePrefix which should strip this Tns prefix from generated names. I guess it is better to move it to separate PR - one PR one feature.

@dderevjanik
Copy link
Owner

@doubleaxe thank you very much! 🚀

@dderevjanik dderevjanik merged commit 98a9011 into dderevjanik:master Jan 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants