refactor: improve install.yaml examples #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler36
reviewed
May 20, 2025
Collaborator
tyler36
left a comment
tyler36
left a comment
There was a problem hiding this comment.
It would be great if we could extract the version number into a variable so we only had to update it in place.
tyler36
reviewed
May 20, 2025
Contributor
Author
|
And bear in mind the only real thing I was trying to showcase was the use of |
stasadev
reviewed
Jul 22, 2025
use ${DDEV_EXECUTABLE}
Co-authored-by: tyler36 <7234392+tyler36@users.noreply.github.com>
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #77 - I cleaned up a lot of my repos and accidentally deleted this fork that closed the PR. I couldn't find a way to re-open that one.
I was trying this with a local compiled version of ddev and obviously I wanted that binary to be used for ddev commands instead of the globally installed one.
I think this is a nice tweak to have in the template so that it's easier to find.
Probably worth adding it to the docs as well.