Skip to content

Conversation

ElliottKasoar
Copy link
Collaborator

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

Adds yaml files for category title, used for the tab, title, etc., and description.

Also combined individual test names/titles into a single name parameter, as we don't need it to be extracted from the file name, and this allows more human-readable text.

Linked issue

Resolves #43

Testing

None

Could use testing from @joehart2001, and improvements to the category descriptions are welcome!

Copy link
Collaborator

@joehart2001 joehart2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will give it a test. I'm also thinking we should add an extended description which is collapsable (think we've discussed briefly before). can add it to the yaml file

@ElliottKasoar
Copy link
Collaborator Author

Looks good, will give it a test. I'm also thinking we should add an extended description which is collapsable (think we've discussed briefly before). can add it to the yaml file

Thanks!

And/or link to the documentation where we describe the category in detail (in addition to each test, as we have at the moment).

@joehart2001
Copy link
Collaborator

Looks good, will give it a test. I'm also thinking we should add an extended description which is collapsable (think we've discussed briefly before). can add it to the yaml file

Thanks!

And/or link to the documentation where we describe the category in detail (in addition to each test, as we have at the moment).

yeah i think would be good to have both, as people may not want to open loads of links and just have a quick glance. will barely take up any space when colapsed and should be simple to add

@joehart2001
Copy link
Collaborator

Looks good, will give it a test. I'm also thinking we should add an extended description which is collapsable (think we've discussed briefly before). can add it to the yaml file

Thanks!

And/or link to the documentation where we describe the category in detail (in addition to each test, as we have at the moment).

just tested and works as expected! Also, sorting the cols appears to update the linked interactive plot correctly too which is great and didn't realise worked yet

@ElliottKasoar
Copy link
Collaborator Author

(Rebased)

@coveralls
Copy link

coveralls commented Sep 23, 2025

Pull Request Test Coverage Report for Build 17948956721

Details

  • 0 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on add-cat-details at 2.273%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ml_peg/app/build_app.py 0 14 0.0%
Totals Coverage Status
Change from base Build 17948025629: 2.3%
Covered Lines: 3
Relevant Lines: 132

💛 - Coveralls

@ElliottKasoar ElliottKasoar merged commit 6f45f6e into ddmms:main Sep 23, 2025
7 checks passed
@ElliottKasoar ElliottKasoar deleted the add-cat-details branch September 23, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set tab/category name
4 participants