forked from google/swiftshader
-
Notifications
You must be signed in to change notification settings - Fork 0
sync to google master #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ddrmax
wants to merge
4,259
commits into
ddrmax:master
Choose a base branch
from
google:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1ff8 0174dd11ff8 BUILD.gn: Make MSVC report the correct __cplusplus value (#5088) 64ba112ffb1 build: refactorize update_build_version (#5079) 96c5dac559f Roll external/re2/ ba541565b..8afcf7fcc (1 commit) (#5085) 5db6c38e656 Revert "spirv-val: Initial SPV_EXT_mesh_shader builtins (#5080)" (#5084) 57fb3c7a3f1 Align git-sync-deps and CMake to use external/spirv-headers by default (#4963) af15e5adeab Roll external/re2/ 954656f47..ba541565b (1 commit) (#5083) 7f9184a5b21 kokoro: fix dubious ownership (#5082) fe087cd5f0e Revert "kokoro: fix dubious ownership (#5078)" (#5081) f0b900ed9a1 spirv-val: Initial SPV_EXT_mesh_shader builtins (#5080) 8fbb53dae49 kokoro: fix dubious ownership (#5078) cdc4e528f3d build: move from c++11 to c++17 (#4983) c51e2afe001 Add kokoro:run label to autoroll PRs (#5077) b6498eac1e0 Limit when the github action bazel builds run (#5071) bb1c885956e Roll external/spirv-headers/ d13b52222..aa331ab0f (5 commits) (#5074) bebca22e2d4 Rename bot in autoroll.yml (#5072) 1e85dca570f Add VS2019 kokoro configs (#5059) 4683eab649c Create a github action to update DEPS (#5061) f36a8d47f73 Start v2023.2 release. (#5066) 63de608daeb Finalize v2023.1 release. (#5065) b184efe2d4c Revert "Finalize v2023.1 release (#5062)" (#5064) 0fc5526f2b0 Finalize v2023.1 release (#5062) 30e51ceaab2 Add #5049 to release v2023.1. (#5058) ba4c9fe5346 Instrument: Fix bindless checking for BufferDeviceAddress (#5049) 0e6fbba7762 Prepare for v2023.1 release (#5057) 1dad9914410 cmake: Modernize install(TARGET) usage (#5056) ae893db200e cmake: Remove old policy code (#5055) ae8d50709fc Add Github Actions to test Bazel builds. (#5043) 7e8813bb4cf Validate version 5 of clspv reflection (#5050) bfd278617c3 utils: repos use 'main' as main devlopment branch (#5054) 631f9bcb5e6 Update README.md: Development occurs on the "main" branch (#5053) f62e121b0df spirv-val: Use more specific term 'switch header' in error message (#5048) d87f61605b3 DEPS: update to last googletest release supporting C++11 (#5045) f416d39bb80 Bazel: Use @platforms//os:windows instead of @build_tools//src/conditions:windows (#5042) 077b09c32a9 Add exported CMake config file for binaries in ./tools/ (#5034) bbdd0fefda0 Update minimum required CMake to 3.17.2 (#5041) 01a3b9bec73 git-sync-deps: Use argparse, and print better help (#5038) 6b5a00eb2ba Kokoro CI bots use git-sync-deps to get sources (#5031) c5d23164305 Enforce layering_check in Bazel build rules. (#5032) 5bec0884cfa Remove testing support for VS2015 (#5027) 29375382108 Fix undef behaviour in hex float parsing (#5025) 025ea891faa Optimize allocation of spvtools::opt::Instruction::operands_ (#5024) 1c287b03d3d First attempt to set up CI-windows-msvc-2017-release-bazel build (#5023) f64a4b64b72 [spirv-opt] Clone names for new struct in EliminateIODeadComponents (#5016) cc81529f4b1 Test operator overloads for SPIR-V C++ mask enums (#5021) 5a78d798f7b Fix layout validation (#5015) 451ba8ec3df README.md: The validator now handles larger limits (#5003) 6b2318aec8d Fix for bug KhronosGroup/SPIRV-Tools#5017 (#5019) 5d6adbdee06 Require C++11 *or later* (#5020) git-subtree-dir: third_party/SPIRV-Tools git-subtree-split: 0174dd11ff8fc2e039815e4ae9f9bc1c626beb49 Change-Id: I73985595c9b46daf31fec976efed5debef83c873
Changes: 0174dd11ff8 BUILD.gn: Make MSVC report the correct __cplusplus value (#5088) 64ba112ffb1 build: refactorize update_build_version (#5079) 96c5dac559f Roll external/re2/ ba541565b..8afcf7fcc (1 commit) (#5085) 5db6c38e656 Revert "spirv-val: Initial SPV_EXT_mesh_shader builtins (#5080)" (#5084) 57fb3c7a3f1 Align git-sync-deps and CMake to use external/spirv-headers by default (#4963) af15e5adeab Roll external/re2/ 954656f47..ba541565b (1 commit) (#5083) 7f9184a5b21 kokoro: fix dubious ownership (#5082) fe087cd5f0e Revert "kokoro: fix dubious ownership (#5078)" (#5081) f0b900ed9a1 spirv-val: Initial SPV_EXT_mesh_shader builtins (#5080) 8fbb53dae49 kokoro: fix dubious ownership (#5078) cdc4e528f3d build: move from c++11 to c++17 (#4983) c51e2afe001 Add kokoro:run label to autoroll PRs (#5077) b6498eac1e0 Limit when the github action bazel builds run (#5071) bb1c885956e Roll external/spirv-headers/ d13b52222..aa331ab0f (5 commits) (#5074) bebca22e2d4 Rename bot in autoroll.yml (#5072) 1e85dca570f Add VS2019 kokoro configs (#5059) 4683eab649c Create a github action to update DEPS (#5061) f36a8d47f73 Start v2023.2 release. (#5066) 63de608daeb Finalize v2023.1 release. (#5065) b184efe2d4c Revert "Finalize v2023.1 release (#5062)" (#5064) 0fc5526f2b0 Finalize v2023.1 release (#5062) 30e51ceaab2 Add #5049 to release v2023.1. (#5058) ba4c9fe5346 Instrument: Fix bindless checking for BufferDeviceAddress (#5049) 0e6fbba7762 Prepare for v2023.1 release (#5057) 1dad9914410 cmake: Modernize install(TARGET) usage (#5056) ae893db200e cmake: Remove old policy code (#5055) ae8d50709fc Add Github Actions to test Bazel builds. (#5043) 7e8813bb4cf Validate version 5 of clspv reflection (#5050) bfd278617c3 utils: repos use 'main' as main devlopment branch (#5054) 631f9bcb5e6 Update README.md: Development occurs on the "main" branch (#5053) f62e121b0df spirv-val: Use more specific term 'switch header' in error message (#5048) d87f61605b3 DEPS: update to last googletest release supporting C++11 (#5045) f416d39bb80 Bazel: Use @platforms//os:windows instead of @build_tools//src/conditions:windows (#5042) 077b09c32a9 Add exported CMake config file for binaries in ./tools/ (#5034) bbdd0fefda0 Update minimum required CMake to 3.17.2 (#5041) 01a3b9bec73 git-sync-deps: Use argparse, and print better help (#5038) 6b5a00eb2ba Kokoro CI bots use git-sync-deps to get sources (#5031) c5d23164305 Enforce layering_check in Bazel build rules. (#5032) 5bec0884cfa Remove testing support for VS2015 (#5027) 29375382108 Fix undef behaviour in hex float parsing (#5025) 025ea891faa Optimize allocation of spvtools::opt::Instruction::operands_ (#5024) 1c287b03d3d First attempt to set up CI-windows-msvc-2017-release-bazel build (#5023) f64a4b64b72 [spirv-opt] Clone names for new struct in EliminateIODeadComponents (#5016) cc81529f4b1 Test operator overloads for SPIR-V C++ mask enums (#5021) 5a78d798f7b Fix layout validation (#5015) 451ba8ec3df README.md: The validator now handles larger limits (#5003) 6b2318aec8d Fix for bug KhronosGroup/SPIRV-Tools#5017 (#5019) 5d6adbdee06 Require C++11 *or later* (#5020) Commands: ./third_party/update-spirvtools.sh Bug: b/123642959 Change-Id: I0ccf8a7c483f3be9aa37f2e749e02e6d5afdeb5e
If VK_SEMAPHORE_WAIT_ANY_BIT is set, the current behavior is to avoid waiting and the semaphore's current value is exactly the value waited for. If VK_SEMAPHORE_WAIT_ANY_BIT is not set but there is a non-infinte timeout, the current behavior is to call wait_until with the criterion that the counter reaches the exact value waited for. In both cases, larger values should also be accepted. Change-Id: I8e447501cc1d09d2071c95398663ec06b444106d Bug: b/265933001 Tests: dEQP-VK.synchronization.basic.timeline_semaphore.* Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70648 Presubmit-Ready: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com>
e9dc2c8ce Roll external/googletest/ ebedaa18c..2f2e72bae (4 commits) (#5099) 7823b8ff4 build: allow update_build to generate fake version (#5098) cac9a5a3e Fix null pointer in FoldInsertWithConstants. (#5093) fd1e650cf Validate decoration of structs with RuntimeArray (#5094) 589076373 instrument: Clean up generation code (#5090) d8759a140 build: fix bazel build for c++17 (#5097) 1a49b5218 Remove vs2017 no longer being run (#5095) 0994ca45b Add C interface for Optimizer (#5030) 8a0fe779e Roll external/re2/ 8afcf7fcc..b025c6a3a (1 commit) (#5091) b230a7c7d Validate operand type before operating on it (#5092) fcfc3c580 build: stop parsing CHANGES file. (#5067) git-subtree-dir: third_party/SPIRV-Tools git-subtree-split: e9dc2c8ce12df55514546511abd19afdf6980cc7 Change-Id: I590a161a8cdb6e5f45611dafce14172cda3fd342
Changes: e9dc2c8ce Roll external/googletest/ ebedaa18c..2f2e72bae (4 commits) (#5099) 7823b8ff4 build: allow update_build to generate fake version (#5098) cac9a5a3e Fix null pointer in FoldInsertWithConstants. (#5093) fd1e650cf Validate decoration of structs with RuntimeArray (#5094) 589076373 instrument: Clean up generation code (#5090) d8759a140 build: fix bazel build for c++17 (#5097) 1a49b5218 Remove vs2017 no longer being run (#5095) 0994ca45b Add C interface for Optimizer (#5030) 8a0fe779e Roll external/re2/ 8afcf7fcc..b025c6a3a (1 commit) (#5091) b230a7c7d Validate operand type before operating on it (#5092) fcfc3c580 build: stop parsing CHANGES file. (#5067) Commands: ./third_party/update-spirvtools.sh Bug: b/123642959 Change-Id: Icd615355a6454cccf23625f48f56fdda5cc998d2
Bug: angleproject:7878 Change-Id: Iae34aa26674aaf2c25d58c64d77b8a949c8db96d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70688 Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Presubmit-Ready: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Forbes <chrisforbes@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com>
* changes: Update SPIR-V Tools to 2f2e72bae Squashed 'third_party/SPIRV-Tools/' changes from 0174dd11f..e9dc2c8ce
Nearly all changes are to the old LLVM sources. I largely did not attempt to backport the upstream compile fixes, and simply fixed in expedient ways. https://issuetracker.google.com/issues/268597958 covers updating to a newer LLVM, which would contain the upstream fixes along the way. Bug: chromium:1284275 Change-Id: I32391593dfe052579a35083abc8a998da5d4667b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70768 Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Presubmit-Ready: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Commit-Queue: Peter Kasting <pkasting@google.com> Tested-by: Peter Kasting <pkasting@google.com>
There's no need to force C++17 (to gain C++17 features) since Chromium has long built in C++17 mode, and in fact this hinders moving to C++20. Use the version of C++ that the surrounding environment defaults to. Bug: chromium:1284275 Change-Id: Ia4aade7891e42fe39d55e8049fdc84a8b2e6e51e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70769 Commit-Queue: Peter Kasting <pkasting@google.com> Presubmit-Ready: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Peter Kasting <pkasting@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
Remove ATOMIC_VAR_INIT() as it's deprecated and never did anything. Bug: chromium:1284275 Change-Id: I15d39bccd0da4985f9a18c2cbf82e093520a4226 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70788 Commit-Queue: Peter Kasting <pkasting@google.com> Tested-by: Peter Kasting <pkasting@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
This is almost entirely taken from the upstream llvm/llvm-project@9231045, except for the fix to MachineOutliner.cpp, which no longer existed in the tree at that point. Bug: chromium:1284275 Change-Id: Icb72e3cb9336f346d8bba2cf1449d3042522f219 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70808 Commit-Queue: Peter Kasting <pkasting@google.com> Tested-by: Peter Kasting <pkasting@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
Most were taken from a couple of upstream commites, but the change to lib/IR/DebugInfo.cpp is my own (since upstream changed significantly before starting to build with C++20). Bug: chromium:1284275 Change-Id: Ib8d88849d85d62c6c54d0ae448acfa3e980617cd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70828 Commit-Queue: Peter Kasting <pkasting@google.com> Tested-by: Peter Kasting <pkasting@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
There's a security issue reported in 0.3.7. Upstreaming of: #22 Bug: None Change-Id: I68be3bec7904f93971c10a41c8239e7a13ff93b3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70848 Commit-Queue: Ben Clayton <bclayton@google.com> Presubmit-Ready: Ben Clayton <bclayton@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com> Tested-by: Ben Clayton <bclayton@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
Yet another attempt to work around the sanitizer false positives. This introduces the use of global static initializers, which I was half expecting Chromium builds to complain about, but there's not much I can do about that (in a performant way). Bug: chromium:1337597 Change-Id: Ie8c20252fbf357a285045362b82b6b3cde52ea77 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70888 Tested-by: Ben Clayton <bclayton@google.com> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: Geoff Lang <geofflang@google.com> Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
Bug: chromium:1337597 Change-Id: I132c441f0b44035ba4d4b7b14da1953eadcc09e9 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70908 Kokoro-Result: kokoro <noreply+kokoro@google.com> Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by: Ben Clayton <bclayton@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
The current implementation of TimelineSemaphore has a number of problems: 1. Shared::signal only works properly when the value signaled is exactly the same as the value waited for. 2. Dependents added to a semaphore are never cleaned up, so each wait-for-any operation on a semaphore adds one more dependent. This leads to long signaling times after a few thousand waits. 3. There's a race between checking for the current value of a timeline semaphore and adding the dependent to the 'any' semaphore. This causes waits to sometimes hang indefinitely. Since the Shared part of TimelineSemaphore seems to exist solely to support wait-for-any, this CL removes it in favor of a simpler implementation without shared_ptrs. That behavior is instead implemented by the WaitForAny object, which is intended to live on the stack and which will clean up after itself during destruction. Change-Id: Ie82c0a5520708c6dda90f594ffdd467a0d927a75 Bug: b/265933001 Tests: dEQP-VK.synchronization.basic.timeline_semaphore.* Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70868 Tested-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Presubmit-Ready: Shahbaz Youssefi <syoussefi@google.com>
SwiftShader incorrectly accessed nonexistant components of the texel operand of an ImageWrite instruction. For example, even in the case of a 1D image write (where the texel has 1 component), SwiftShader would still emit code to access 4 components. Despite the components not being used in the final JITted code, accessing the data structure holding the operand's components at compile time resulted in out-of-bounds accesses. I have also added assertions that accesses into an operand's components are always in-bounds (assertions already existed when the operand was an intermediate but not when it was a constant). Bug: None Change-Id: I85ba79b18ef82f1ef676aafe2639a289372e254b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70968 Commit-Queue: Daniele Vettorel <dvet@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Daniele Vettorel <dvet@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com>
Change-Id: I06c5714e5615e2e23b7f115c758f4812c9c146ad Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70948 Reviewed-by: Geoff Lang <geofflang@google.com> Tested-by: Jean-François Geyelin <jif@google.com> Commit-Queue: Jean-François Geyelin <jif@google.com>
The scripts will be updated to roll LLVM 16 in a follow up CL. Bug: b/272710814 Change-Id: I8f0abc2ab30d4bc87df45b1d89727b3885d2b9d6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70949 Tested-by: Jean-François Geyelin <jif@google.com> Commit-Queue: Jean-François Geyelin <jif@google.com> Reviewed-by: Geoff Lang <geofflang@google.com>
The CL is for the most part changing '10' to '16'. Extra changes: * Add `/cmake/` to `.git/info/sparce-checkout`. See llvm/llvm-project#53281 * Turn OFF `LLVM_INCLUDE_BENCHMARKS` and `LLVM_INCLUDE_TESTS`. * Copy generated files from additional directories: - include/llvm/TargetParser - include/llvm/Frontend - lib/ExecutionEngine Bug: b/272710814 Change-Id: I5e18df6ba54ade60fd0e0c13069749342af99a0e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/70950 Commit-Queue: Jean-François Geyelin <jif@google.com> Reviewed-by: Geoff Lang <geofflang@google.com> Tested-by: Jean-François Geyelin <jif@google.com>
9c689c9a8 Add MARL_USE_PTHREAD_THREAD_LOCAL option abd033696 Explicitly #include <utility> in finally.h 2e82e6999 Fix build issue with GetModuleHandle when using UNICODE 40b9a1c47 gcc -Wshadow warning fixes git-subtree-dir: third_party/marl git-subtree-split: 9c689c9a88bd8c6a8fe48b01d5ec6b71974282a6 Change-Id: I03c1b559c7c3fc8d5afde198543d6e5eb6100af6
Changes: 9c689c9a8 Add MARL_USE_PTHREAD_THREAD_LOCAL option abd033696 Explicitly #include <utility> in finally.h 2e82e6999 Fix build issue with GetModuleHandle when using UNICODE 40b9a1c47 gcc -Wshadow warning fixes Commands: ./third_party/update-marl.sh Bug: b/140546382 Change-Id: I0fe71df4ca087650fd1d9cb81c816c2d8d41dcfb
This bit-rotted over the last couple of years. Make it usable again. Bug: none Change-Id: I03faffec80f2c8c29798d7842480e26bdbc3c1f2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/71108 Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by: Ben Clayton <bclayton@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com> Kokoro-Result: Ben Clayton <bclayton@google.com>
SwiftShader is not currently developing new major features, and most changes are now community contributions. Most changes do not have a corresponding Monorail issue to link against, so requiring a 'Bug:' in the commit message causes more grief than benefit. Drop the presubmit requirement. Change-Id: I91320814a8222f7d802525a0c3ea35efb1efd284 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/71128 Kokoro-Result: kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com> Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by: Ben Clayton <bclayton@google.com> Reviewed-by: Geoff Lang <geofflang@google.com>
Change-Id: I8df23060bbfaae54e4df49039f83d33fc9dde814 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/71148 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Tested-by: Jean-François Geyelin <jif@google.com> Commit-Queue: Jean-François Geyelin <jif@google.com>
GCC 12 fails to build swiftshader from CMake with recent libstdc++ because of using deprecated declarations in the LLVM 10 copy inside SwiftShader. This change removes those warnings, as they were also removed in Clang. Bug: swiftshader:181 Change-Id: I1daf7812a8d696dcdbf98626bf39c125163cd828 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/71090 Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
This is a direct backport of commit 95d0d8e9e9d10da3cfa503fbba405e740aea3cc1 from Richard Smith: From: Richard Smith <richard@metafoo.co.uk> Date: Tue, 23 Feb 2021 14:07:13 -0800 Subject: Fix constructor declarations that are invalid in C++20 onwards. Fix constructor declarations that are invalid in C++20 onwards. Under C++ CWG DR 2237, the constructor for a class template C must be written as 'C(...)' not as 'C<T>(...)'. This fixes a build failure with GCC in C++20 mode. In passing, remove some other redundant '<T>' qualification from the affected classes. Bug: chromium:819294 Change-Id: I51a7f069d355d4932f4b50640fedbba1d5773f0b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/71088 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com>
From GCC 12, the missing template keyword warning will break build. As this warning is new in GCC 12, this change disables it for that version or newer. Bug: swiftshader:182 Change-Id: I27e766a0e62bee7a004f66b0b3c57afcd4df5a4b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/71091 Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
It was previously included transitively through some other header, but with recent libc++ versions that's no longer the case. Bug: chromium:1425830 Change-Id: I91aa90e7b4b2d4b02b780b0efef5339d88fbc987 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/71168 Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com>
Partial backport of llvm-project patch: commit 2ccf0b76bcaf0895e04f14e3ff53c59dd96f9f0f Author: Evgeny Mandrikov <mandrikov@gmail.com> Date: Thu Jan 6 17:01:05 2022 +0100 Fix build failure with GCC 11 in C++20 mode See https://wg21.link/cwg2237 Reviewed By: shafik, dexonsmith Differential Revision: https://reviews.llvm.org/D115355 Bug: chromium:819294 Change-Id: I90d58b6fc601f9a4f615e2f6edc13a73ce848e4f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/71089 Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com>
Turns off new warning found by the latest llvm compiler, which becomes a build error under -Werror. Change-Id: Ib122c502ea7e9fe0c0d111a12a44c11d4074bbdb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75148 Tested-by: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com>
Reactor backend: Subzero Change-Id: I48290f563dd36798f5ad8763fff34b43361b2b91 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75168 Tested-by: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Presubmit-Ready: Yuly Novikov <ynovikov@chromium.org> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com>
Reactor backend: Subzero Change-Id: Id33c0b21deeef4d5adcf5d05bdb0a13e6b9f838f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75188 Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Presubmit-Ready: Yuly Novikov <ynovikov@chromium.org> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Bug: chromium:378273309 Bug: chromium:378273295 Change-Id: I3904f048466fde0f5bf9419ac3285d954fb6ad47 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75208 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Geoff Lang <geofflang@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com>
Reactor backend: Subzero Change-Id: I8a0421e6ae5735d6c84d8c0068dd8e5075770e57 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75228 Presubmit-Ready: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Tested-by: Yuly Novikov <ynovikov@chromium.org> Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reactor backend: Subzero Change-Id: Ia6f0fde01ecb97021e7c63343a0a9cfb1418f799 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75248 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Presubmit-Ready: Yuly Novikov <ynovikov@chromium.org>
Reactor backend: Subzero Change-Id: Iced8b580f0cee192a21689390df230418e21e437 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75268 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Yuly Novikov <ynovikov@chromium.org> Presubmit-Ready: Yuly Novikov <ynovikov@chromium.org>
This is old code, so there's not much point in flagging warnings. Bug: chromium:403236787, chromium:368047728 Change-Id: Ib3bbd15036258b1ecef7a04dbe7254196f0caf73 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75288 Tested-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
New suppressions added for Chromium's super recent clang are not known warnings in the clang versions used by other projects (in this case Dawn's current clang). Avoid warnings for unknown warnings to not break compilation there. Bug: chromium:403236787, chromium:368047728 Change-Id: Ia946ed95a9a70de1552c666cb61c8e41cd6afd0a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75348 Commit-Queue: Corentin Wallez <cwallez@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Corentin Wallez <cwallez@google.com> Presubmit-Ready: Corentin Wallez <cwallez@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com>
Reactor backend: Subzero Change-Id: I578f0950459640f9a4a1cb80edfc9703e0924d21 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75308 Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Yuly Novikov <ynovikov@chromium.org> Presubmit-Ready: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Test: dEQP-VK.wsi.*.maintenance1.*.null_handles Change-Id: If5b5745dd63fd86934c4e532dbc57a965dbbddef Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75328 Presubmit-Ready: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Chris Forbes <chrisforbes@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com>
Reactor backend: Subzero Change-Id: I30fadc0abdbf61387428d4ec06609768abbfc3d2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75368 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Presubmit-Ready: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Yuly Novikov <ynovikov@chromium.org>
Relevant LLVM API changes: llvm/llvm-project#66295 llvm/llvm-project#71029 llvm/llvm-project#74261 Change-Id: Id5af421c1415cf231dcb6673fa3c3b6f5b106841 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/73168 Reviewed-by: Geoff Lang <geofflang@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com>
This reverts commit 90d72a2. Reason for revert: Breaks build on roll to Android and ANGLE. Change-Id: Ie93177376f7e5e71b1a39cb32611eda492005604 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75408 Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Geoff Lang <geofflang@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com>
Only the main feature, as required by Vulkan 1.3, is exposed. Many projects still create Vulkan 1.1 and rely on the extension to get dynamic state. Bug: b/204502923 Bug: b/246064773 Change-Id: Idb4235bee77cead4bad0c09f5feb0f76a664a5e2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75448 Tested-by: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Chris Forbes <chrisforbes@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reactor backend: Subzero Change-Id: I672efb1f27c4cceb51fd7d7a6afad8c34185cc58 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75388 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Presubmit-Ready: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
This change adds conversions between Vulkan and AHardwareBuffer BGRA formats. Change-Id: If992c80438bf8386e0687c920e04015bab7bf394 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75488 Reviewed-by: Jason Macnak <natsu@google.com> Commit-Queue: Jason Macnak <natsu@google.com> Tested-by: Jason Macnak <natsu@google.com>
Reactor backend: Subzero Change-Id: Ic208aa2fe7842335758e70d1bc3cea83a581697f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75468 Tested-by: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reactor backend: Subzero Change-Id: I77e63069834c7c2f86806169a503ac390b322849 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75508 Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Yuly Novikov <ynovikov@chromium.org> Presubmit-Ready: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Z was compared against height instead of depth. Bug: angleproject:419755713 Change-Id: Ie17a1672e8f3006ec72c1eee9a315832c8d1976a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75548 Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Geoff Lang <geofflang@google.com> Commit-Queue: Geoff Lang <geofflang@google.com> Reviewed-by: Geoff Lang <geofflang@google.com>
Test: dEQP-VK.pipeline.*.device_index_as_view_index.* Test: dEQP-VK.image.host_image_copy.*_remaining_layers Change-Id: Ifd223265430903f3bb139e46721cb231ceaa0e00 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75568 Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reactor backend: Subzero Change-Id: I4043fbb8cf56b58559ea7ba7934708f7f14b7e9e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75528 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
I'm trying to move the same config from service config[1] to project config. [1]:https://chrome-internal.googlesource.com/infradata/config/+/a661f2eec00763dc5279dc4daf7b3586f6c66fec/configs/luci-change-verifier/listener-settings.cfg#75 Bug: 421431364 Change-Id: I5299b7911a8aeb741195ef6e9fbf4185a43de245 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75588 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Yuly Novikov <ynovikov@chromium.org>
Change-Id: Iff892d30e34182907d2ee2f03968c9ee7d0f32d8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75628 Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com>
Reactor backend: Subzero Change-Id: I949839d17092bea2cc7552371261a43e98b4a00b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75608 Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Tested-by: Yuly Novikov <ynovikov@chromium.org> Presubmit-Ready: Yuly Novikov <ynovikov@chromium.org>
Reactor backend: Subzero Change-Id: Icdc1b342eb9284baa4078ee70ce81b2219212d74 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75648 Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Tested-by: Yuly Novikov <ynovikov@chromium.org> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com> Presubmit-Ready: Yuly Novikov <ynovikov@chromium.org>
https://github.com/KhronosGroup/Vulkan-Headers revision 2642d51e1e9230720a74d8c76bc7b301e69881bf tag v1.4.317. Bug: angleproject:422982681 Change-Id: I91e8308a4f1790d40a353faf4fbb73b81208dc4e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75668 Tested-by: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com>
Change-Id: I337f5eb4d247a33fb3208ce6965e64b929f160c9 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75688 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Tested-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Kokoro-Result: kokoro <noreply+kokoro@google.com>
type_traits in vulkan_enums.hpp for underlying_type usage Bug: b/424075772 Change-Id: I24816048b69184932e40c836ae08775ad0e1edd3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75728 Tested-by: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Presubmit-Ready: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
Test: dEQP-VK.*general_layout* Bug: angleproject:422982681 Change-Id: Ia17f5723643f65e3b72fc773ef16cb2af0d4c621 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/75669 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Shahbaz Youssefi <syoussefi@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.