DBZ-848 Adding demo for fail-over in MongoDB replica set #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpechane
approved these changes
Jan 10, 2019
Contributor
jpechane
left a comment
jpechane
left a comment
There was a problem hiding this comment.
@gunnarmorling It is very nice demo, thanks! I've just commented on two minor issues. When the related PR is completed this could be merged.
| $ docker-compose exec mongodb-2 bash -c 'mongo inventory' | ||
|
|
||
| rs0:PRIMARY> db.customers.insert([ | ||
| { \_id : NumberLong("1005"), first_name : 'Bob', last_name : 'Hopper', email : 'thebob@example.com' } |
Contributor
There was a problem hiding this comment.
I think the backslash should not be present
| $ docker-compose exec mongodb-3 bash -c 'mongo inventory' | ||
|
|
||
| rs0:PRIMARY> db.customers.insert([ | ||
| { \_id : NumberLong("1006"), first_name : 'Bob', last_name : 'Hopper', email : 'thebob@example.com' } |
Contributor
There was a problem hiding this comment.
Same as above. Also it might be better to change the other test data not only id
Member
|
❌ Developer Certificate of Origin (DCO) check failed. Hi @gunnarmorling, please sign off all commits with: If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires debezium/container-images#109.