Handle errors more effectively in plugins#23
Open
r8ygun wants to merge 3 commits intodeepfence:mainfrom
Open
Conversation
Contributor
Author
|
@vadorovsky in #20 you mentioned wanting to handle errors more effectively. I'd be interested in your thoughts on what we could do here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing plugins did not handle errors particularly well in that they simply logged them within the context of their executing goroutine, which leaves the rest of the application blind to the errors. This PR attempts to exposed errors outside of their plugin goroutines so that we can be more opinionated on what should happen to a plugin in each case.
For now I have left the behaviour as logging.