fix: macOS biodata encoding compatibility #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
#11 (comment)
Cross-platform encoding compatibility fix
Problem
The current encoding implementation using
multiprocessing.Poolfails on macOS due to its different process forking behavior. This affects users trying to run the encoding function on macOS systems.Solution
Implemented OS-specific parallel processing:
ThreadPoolExecutorfor macOS environmentsmultiprocessing.Poolfor other operating systems (Linux/Windows)Technical Details
multiprocessing.PoolThreadPoolExecutorprovides a more reliable parallel processing solution for macOSplatform.system()to automatically choose the appropriate methodResult after fix:
