feat(weaviate): add tenant support in write_documents with tests (syn…#3056
feat(weaviate): add tenant support in write_documents with tests (syn…#3056Akash504-ai wants to merge 13 commits into
Conversation
1fe6aeb to
73e97f2
Compare
julian-risch
left a comment
There was a problem hiding this comment.
Hello @Akash504-ai Thank you for opening this pull request. I have a couple of smaller change requests, which I explain in more detail below. Please keep comments that are not related to tenant_support unchanged in this pull request. Other than that the code changes look quite good to me already.
| async def test_write_documents_with_tenant_async(self, document_store): | ||
| doc = Document(content="tenant test doc") | ||
|
|
||
| written = await document_store.write_documents_async([doc], tenant="tenant1") |
There was a problem hiding this comment.
This test could check if _write_async get's called with the expected tenant parameter value.
|
Thanks for the suggestion! Initially I implemented the test using |
|
@Akash504-ai Thank you for iterating on this PR. Could you please also address my other change requests and restore comments that this PR removes in its current state? #3056 (review) |
7306942 to
f8a5978
Compare
Coverage report (weaviate)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
I've restored the unrelated comments/docstrings that were modified and addressed the remaining issues from the conflict resolution. All checks are now passing. Please let me know if there's anything else that should be adjusted. |
Related Issues
Proposed Changes
write_documentsandwrite_documents_asyncHow did you test it?
test_write_documents_with_tenanttest_write_documents_with_tenant_asyncNotes for the reviewer
Checklist