Bringing the name of the example projects to a single name #154
+2
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If PR is merged, please trigger rebuild of the examples to update https://defold.com/examples/material/custom_sprite/ with proper files. |
|
Do we anticipate more common settings than the project title? If not, then a simple replace_in_file() should suffice: game_project = os.path.join(example_src_dir, "game.project")
replace_in_file(game_project, r"title = .*", r"title = Defold-example") |
I was thought I could add something else to the settings file (in the future). For now it is not needed, then let it be just an title replacement in the game.project file 🙌 Also, please, then merge the PR - defold/examples#78 |
aglitchman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the root of the project I added a common settings file for all examples, which is applied when building projects via bob.jar. For this purpose, it is copied to the example directory when building it (note: if we specify an absolute path to the settings file, bob.jar does not want to use it because it is outside the example directory).
Closes #153